-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv: use gcc11 for riscv #170991
stdenv: use gcc11 for riscv #170991
Conversation
For the gcc issue: see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100017 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering it's the same change I am using in my PR, and I have a working riscv64 system on hardware with this change, I'd have to say LGTM.
To be honest I think the original gcc 10 -> 11 bump should have just changed it to |
What's the situation now for gcc11 on aarch64? |
Not sure, don't have aarch64 hardware but I'll request access to the community builder. Would be great to get all our tier 1-3 platforms on the same gcc version. |
aarch64-linux is borked on gcc10 and gcc11 afaik and it was recently tested. (Silghtly after the proposed 10 → 11 for x86_64-linux) Though, no aarch64 hardware on my end. |
I was hoping other contributors in other platforms would help with those bumps since there was risk of breakage on platforms I didn't have access to nor would have been able to help with. (mainly tier2, x86_64-darwin and aarch64-{darwin,linux}). Here is the current RFC0046 tiers 1-3:
Need testing/bump to gcc11:
|
This is the PR about gcc11 on aarch64: #167726 This is the latest effort and problem I know about, but I'm not knowledgeable enough to try and fix it. I have fairly powerful aarch64 hardware, so if someone wants me to test a fix I would be happy to. I am very in favor of everything being on gcc11. |
Also, (a dependency of) |
I think we may want to treat that as a special case and use GCC 10 in the all-packages.nix entry, or devise a patch per-case for cases like that. |
Perhaps. The difference is in platforms that noone's tried yet (and specified explicitly there). No idea if the change will help them or harm them. I'd probably leave the default be for 22.05 for those reasons. |
I agree, 22.05 is meant to be stable, and is already too late-stage for a change in default stdenv for tier-1 platforms, no reason to fix what's not broken for a release. |
If |
Description of changes
An increasing number of riscv packages are requiring gcc11 to build likely due to the binutils update to 2.38. And I'm seeing little regression with this change on my hydra apart from gccForLibs which looks like a upstream issue.
ref: #168826
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes