Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] grpc: override abseil to use same std=c++14 version #167129

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Apr 4, 2022

Description of changes

Reported broken on staging on comment: #165732 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabianhjr fabianhjr requested a review from mweinelt April 4, 2022 04:56
@fabianhjr fabianhjr changed the title grpc: override abseil to use same std=c++14 version [staging] grpc: override abseil to use same std=c++14 version Apr 4, 2022
@mweinelt mweinelt requested review from marsam and cpcloud April 4, 2022 13:59
@mweinelt
Copy link
Member

mweinelt commented Apr 8, 2022

Will that affect

] ++ lib.optionals ((stdenv.hostPlatform.useLLVM or false) && lib.versionOlder stdenv.cc.cc.version "11.0") [
# Needs to be compiled with -std=c++11 for clang < 11. Interestingly this is
# only an issue with the useLLVM stdenv, not the darwin stdenv…
# https://github.com/grpc/grpc/issues/26473#issuecomment-860885484
"-DCMAKE_CXX_STANDARD=11"
];

cc @sternenseemann

@sternenseemann
Copy link
Member

sternenseemann commented Apr 8, 2022

That's effectively dead code at this point, since we are defaulting to LLVM 11 or newer for everything but FreeBSD. On FreeBSD it's impossible to reach that point because cmake doesn't build anyway. So that shouldn't be a blocking concern for this PR and that code can probably be cleaned up.

@sternenseemann
Copy link
Member

@ofborg build pkgsLLVM.grpc

@mweinelt
Copy link
Member

mweinelt commented Apr 8, 2022

@ofborg build pkgsLLVM.grpc

CMake Warning at cmake/modules/Findc-ares.cmake:18 (find_package):
  Could not find a configuration file for package "c-ares" that is compatible
  with requested version "1.13.0".

  The following configuration files were considered but not accepted:

    /nix/store/nh777bwrcaz6z8rkzcs40xp80kdwsc67-c-ares-config.cmake/c-ares-config.cmake, version: unknown

Call Stack (most recent call first):
  cmake/cares.cmake:42 (find_package)
  CMakeLists.txt:312 (include)


-- Found c-ares: /nix/store/v5nz29zycv7iw9b85nqh1dqxa8hghbx6-c-ares-x86_64-unknown-linux-gnu-1.18.1/include (found suitable version "1.18.1", minimum required is "1.13.0") 
-- Found Protobuf: /nix/store/0dz9js7a5w0jpg4cwnycdlnl4rm3w5jx-protobuf-x86_64-unknown-linux-gnu-3.19.3/lib/libprotobuf.so (found version "3.19.3") 
-- Found PkgConfig: /nix/store/j44iq4s539mfs03ba6mghr9kgpa9h8za-x86_64-unknown-linux-gnu-pkg-config-wrapper-0.29.2/bin/x86_64-unknown-linux-gnu-pkg-config (found version "0.29.2") 
-- Found RE2 via pkg-config.
-- Found OpenSSL: /nix/store/d2mvw2fzpcql6fabj4qiyan30qy1yhwz-openssl-x86_64-unknown-linux-gnu-1.1.1n/lib/libcrypto.so (found version "1.1.1n")  
CMake Error at /nix/store/c5jhgwlnq0782aqxb7brkpxpb56h5bgh-cmake-3.22.3/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.12")
Call Stack (most recent call first):
  /nix/store/c5jhgwlnq0782aqxb7brkpxpb56h5bgh-cmake-3.22.3/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/c5jhgwlnq0782aqxb7brkpxpb56h5bgh-cmake-3.22.3/share/cmake-3.22/Modules/FindZLIB.cmake:120 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/zlib.cmake:52 (find_package)
  CMakeLists.txt:318 (include)


-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/3rylbb0vg1ypmjhwk59glvmiamll49q7-grpc-x86_64-unknown-linux-gnu-1.44.0.drv' failed with exit code 1

@fabianhjr
Copy link
Member Author

fabianhjr commented Apr 8, 2022

since this PR is to address x86_64-linux gcc: gcc_10 → gcc_11 breakage that llvm issue seems to be unrelated, though currently present on staging.

Have no way to help since on the platform I am on doesn't have that issue: pkgsLLVM.grpc on x86_64-linux — Success

https://github.com/NixOS/nixpkgs/pull/167129/checks?check_run_id=5886474017

@mweinelt mweinelt merged commit 6443a5d into NixOS:staging Apr 8, 2022
@sternenseemann
Copy link
Member

Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.12")

Possibly another zlib cross issue? cc @Mindavi

@fabianhjr fabianhjr deleted the staging-fix-grpc branch April 8, 2022 23:32
@marsam marsam mentioned this pull request Nov 2, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants