-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging] grpc: override abseil to use same std=c++14 version #167129
Conversation
Will that affect nixpkgs/pkgs/development/libraries/grpc/default.nix Lines 67 to 72 in f918093
|
That's effectively dead code at this point, since we are defaulting to LLVM 11 or newer for everything but FreeBSD. On FreeBSD it's impossible to reach that point because |
@ofborg build pkgsLLVM.grpc |
|
since this PR is to address Have no way to help since on the platform I am on doesn't have that issue: https://github.com/NixOS/nixpkgs/pull/167129/checks?check_run_id=5886474017 |
Possibly another zlib cross issue? cc @Mindavi |
Description of changes
Reported broken on staging on comment: #165732 (comment)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes