Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: let aarch64 use gcc ≥10 #108305

Closed
FRidh opened this issue Jan 3, 2021 · 16 comments · Fixed by #209870
Closed

stdenv: let aarch64 use gcc ≥10 #108305

FRidh opened this issue Jan 3, 2021 · 16 comments · Fixed by #209870
Labels
0.kind: bug Something is broken 1.severity: blocker This is preventing another PR or issue from being completed 6.topic: stdenv Standard environment
Milestone
23.05

Comments

@FRidh
Copy link
Member

FRidh commented Jan 3, 2021 •
edited by dotlambda
Loading

Describe the bug
Nixpkgs upgraded to gcc 10 in #89793. Unfortunately, there were issues with aarch64 so aarch64 still uses gcc 9.
@FRidh FRidh added the 0.kind: bug Something is broken label Jan 3, 2021
@FRidh FRidh added this to the 21.03 milestone Jan 3, 2021
@FRidh FRidh added the 1.severity: blocker This is preventing another PR or issue from being completed label Jan 4, 2021
This was referenced Jan 4, 2021
Merged
Closed
@FRidh FRidh changed the title let aarch64 use gcc 10 stdenv: let aarch64 use gcc 10 Jan 4, 2021
@FRidh FRidh added the 6.topic: stdenv Standard environment label Jan 4, 2021
@stale
Copy link

stale bot commented Nov 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2021
@sternenseemann sternenseemann removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 30, 2021
@ajs124 ajs124 mentioned this issue Jan 3, 2022
Merged
13 tasks
@ajs124 ajs124 mentioned this issue Apr 7, 2022
Closed
13 tasks
@ajs124 ajs124 mentioned this issue Apr 22, 2022
Merged
13 tasks
@dotlambda dotlambda mentioned this issue May 13, 2022
Merged
13 tasks
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@Artturin Artturin removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 3, 2022
@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jul 22, 2022 •
edited
Loading

Is there any progress on this issue? I maintain a package that has ICE with gcc 9 and has #108111 with gcc 10 on aarch64, so it was marked as broken on aarch64 in #173671 (and I have completely no idea how to un-break it as it seems all nixpkgs compilers just fail on it due to those issues).

@ajs124
Copy link
Member

ajs124 commented Jul 22, 2022

See #167726 (comment)

@dotlambda
Copy link
Member

In #153329 adding gcc11 to nativeBuildInputs did the trick.

@ilya-fedin
Copy link
Contributor

🤔 changing stdenv to gcc11Stdenv doesn't work?

@dotlambda
Copy link
Member

🤔 changing stdenv to gcc11Stdenv doesn't work?

True. That's a cleaner solution if it does work in your case.

@Artturin Artturin changed the title stdenv: let aarch64 use gcc 10 stdenv: let aarch64 use gcc ≥10 Aug 18, 2022
@Artturin Artturin mentioned this issue Sep 2, 2022
Closed
13 tasks
@K900
Copy link
Contributor

K900 commented Oct 12, 2022

Another blocker: #191357

@zzywysm zzywysm mentioned this issue Nov 28, 2022
Closed
@Artturin Artturin mentioned this issue Dec 12, 2022
Merged
13 tasks
@Artturin Artturin modified the milestones: 21.05, 23.05 Dec 31, 2022
This was referenced Jan 7, 2023
Closed
Merged
@K900
Copy link
Contributor

K900 commented Jan 15, 2023

Another victim: #210859

@roberth roberth mentioned this issue Feb 1, 2023
Merged
@roberth
Copy link
Member

roberth commented Feb 1, 2023

Another victim:

@roberth
Copy link
Member

roberth commented Feb 1, 2023

Potential solution:

(If I may summarize what can be inferred from the issue page)

@ghost
Copy link

ghost commented Feb 12, 2023

FWIW the commit message and leading comment for #209870 both contain this text:

- Closes #108305

but for some reason github isn't processing it.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Feb 12, 2023 •
edited
Loading

but for some reason github isn't processing it.

изображение
изображение

@K900
Copy link
Contributor

K900 commented Feb 12, 2023

Github is having a pretty bad day it seems, it'll probably catch up in a bit.

@ghost
Copy link

ghost commented Feb 13, 2023

but for some reason github isn't processing it.

Specifically, this PR doesn't show a "merging #209870 may close this bug" or list this as a "linked issue" of that PR. It should say "Development Successfully merging this pull request may close these issues: #209870"

For an example of what it should look like, check out e.g. number 216163 (no hyperlink to avoid noise in that PR).

@K900
Copy link
Contributor

K900 commented Feb 14, 2023

Note to self: 6d6a980 will need to be reverted when any of the solutions land.

@ilya-fedin ilya-fedin mentioned this issue Mar 16, 2023
Merged
12 tasks
@wegank wegank closed this as completed Mar 16, 2023
@dotlambda
Copy link
Member

@wegank Can you link the PR in which this was fixed?

@wegank wegank mentioned this issue Mar 16, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken 1.severity: blocker This is preventing another PR or issue from being completed 6.topic: stdenv Standard environment
Projects
None yet
Milestone
23.05
Development

Successfully merging a pull request may close this issue.

stdenv: Nix-driven bootstrap of gcc
9 participants
@K900 @roberth @ajs124 @FRidh @sternenseemann @dotlambda @wegank @ilya-fedin @Artturin