Skip to content

Commit

Permalink
hll2390dw-cups: Drop unmaintained package
Browse files Browse the repository at this point in the history
  • Loading branch information
@samueldr
samueldr committed Jun 21, 2024
1 parent 14afd33 commit c7882d9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 74 deletions.
72 changes: 0 additions & 72 deletions pkgs/misc/cups/drivers/hll2390dw-cups/default.nix
View file

This file was deleted.

1 change: 1 addition & 0 deletions pkgs/top-level/aliases.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,7 @@ mapAliases ({
hip-amd = throw "'hip-amd' has been removed in favor of 'rocmPackages.clr'"; # Added 2023-10-08
hip-common = throw "'hip-common' has been replaced with 'rocmPackages.hip-common'"; # Added 2023-10-08
hip-nvidia = throw "'hip-nvidia' has been removed in favor of 'rocmPackages.clr'"; # Added 2023-10-08
hll2390dw-cups = throw "The hll2390dw-cups package was dropped since it was unmaintained."; # Added 2024-06-21
ht-rust = xh; # Added 2021-02-13
hydra-unstable = hydra_unstable; # added 2022-05-10
hyper-haskell = throw "'hyper-haskell' has been removed. reason: has been broken for a long time and depends on an insecure electron version"; # Added 2024-03-14
Expand Down
2 changes: 0 additions & 2 deletions pkgs/top-level/all-packages.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39869,8 +39869,6 @@ with pkgs;

canon-cups-ufr2 = callPackage ../misc/cups/drivers/canon { };

hll2390dw-cups = callPackage ../misc/cups/drivers/hll2390dw-cups { };

mfc465cncupswrapper = callPackage ../misc/cups/drivers/brother/mfc465cncupswrapper { };
mfc465cnlpr = callPackage ../misc/cups/drivers/brother/mfc465cnlpr { };

Expand Down

2 comments on commit c7882d9

@tjkirch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is still working perfectly - it doesn't really need maintenance. Why would it be dropped?

@samueldr
Copy link
Member Author

@samueldr samueldr commented on c7882d9 Jun 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I must have lost the commit message explaining it while rebasing.

TLDR: it's probably not needed, since it works via IPP everywhere. And it might have had issues with page size. Way back when I used it still, I had to patch it in my local overlay to force Letter size; it would print A4 page size on Letter otherwise.

TBF, it probably needed to be removed the moment I realized that issue, or the issue further investigated, and understood to see if it affects/affected other drivers.

Though feel free to fish it back and maintain it.

Please sign in to comment.