Code

Refactor Error Types#24

Code

Merged

philiptaron merged 19 commits intoNixOS:mainNixOS/nixpkgs-vet:mainfrom willbush:by-name-consistent-errorsCopy head branch name to clipboardMar 26, 2024

+475-504

Commits

Commits on Mar 22, 2024

• Remove superfluous error field relative_package_file

  Show description for a169008
  willbush

  committed
  a169008

  Copy full SHA for a169008

• Rename package_name field in InvalidPackageName error

  Show description for d12e15a
  willbush

  committed
  d12e15a

  Copy full SHA for d12e15a

• Derive relative_package_dir from the package name for PackageNonDir

  willbush

  committed
  0bb6405

  Copy full SHA for 0bb6405

• Refactor ratchet problems into a struct with common fields

  willbush

  committed
  f8bdeab

  Copy full SHA for f8bdeab

Commits on Mar 23, 2024

• Remove unnecessary braces

  willbush

  committed
  5c502a2

  Copy full SHA for 5c502a2

• Group shard problems into a struct for shared context

  willbush

  committed
  9391e85

  Copy full SHA for 9391e85

• Fix clippy warnings

  willbush

  committed
  686cbbc

  Copy full SHA for 686cbbc

• Refactor nix file problems into a struct with common fields

  willbush

  committed
  94244b0

  Copy full SHA for 94244b0

Commits on Mar 24, 2024

• Refactor ByNameOveride problems into a struct with common fields

  willbush

  committed
  7eaa754

  Copy full SHA for 7eaa754

• Refactor check_nix_file to use to_problem closure

  willbush

  committed
  d32d4cf

  Copy full SHA for d32d4cf

• Refactor ByName problems into a struct with common fields

  willbush

  committed
  797f201

  Copy full SHA for 797f201

• Refactor Path related problems into a struct with common fields

  willbush

  committed
  e5aa63d

  Copy full SHA for e5aa63d

• Refactor Package related problems into a struct with common fields

  Show description for b0d270e
  willbush

  committed
  b0d270e

  Copy full SHA for b0d270e

• Refactor some nixpkgs_problem imports

  willbush

  committed
  81e45fa

  Copy full SHA for 81e45fa

Commits on Mar 26, 2024

• Fix clone of node by moving variables above usage of cast

  willbush

  committed
  25adca4

  Copy full SHA for 25adca4

• Change most to_problem closures into to_validation

  Show description for 2ed5984
  willbush

  committed
  2ed5984

  Copy full SHA for 2ed5984

• Replace RatchetErrorKind with is_new and is_empty bools

  willbush

  committed
  c57206d

  Copy full SHA for c57206d

• Rename RatchetError to TopLevelPackageError

  willbush

  committed
  bcc472d

  Copy full SHA for bcc472d

• Add comments to NixpkgsProblem struct sub-types

  willbush

  committed
  591be8e

  Copy full SHA for 591be8e