Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specialisation for Lenovo Yoga Slim 7 Pro-X 14ARH7 #852

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

mexisme
Copy link
Contributor

@mexisme mexisme commented Feb 2, 2024

Description of changes

Add specialisation for Lenovo Yoga Slim 7 Pro-X 14ARH7

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@mexisme mexisme force-pushed the lenovo/add/yoga-7-prox-14arh7 branch 4 times, most recently from 723d3b3 to ce8fc4a Compare February 2, 2024 08:22
@mexisme mexisme marked this pull request as ready for review February 2, 2024 08:22
@mexisme mexisme marked this pull request as draft February 2, 2024 08:37
@mexisme mexisme force-pushed the lenovo/add/yoga-7-prox-14arh7 branch from ce8fc4a to 30f810d Compare February 2, 2024 09:16
@mexisme mexisme marked this pull request as ready for review February 2, 2024 09:22
@mexisme
Copy link
Contributor Author

mexisme commented Feb 5, 2024

At the moment, to support booting with only AMD-GPU or NVidia support, two variations are provided.

I'm not convinced this is the best way, as opposed to (say) adjusting the //common/gpu/amd/ and //common/gpu/nvidia/ files to make them selectable via options rather than just from different imports.

However, the "two variations" way doesn't touch these files, that quite a few other hardware targets also rely on.

(Also, see #853 (comment))

@Mic92
Copy link
Member

Mic92 commented Feb 6, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Feb 6, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6e5cc38

@mergify mergify bot merged commit 6e5cc38 into NixOS:master Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants