Add Framework 13 Ryzen 7040 Series

[kjhoerr]

Note: It may be prudent to reorganize the structure of these changes slightly since the Framework Laptop 16 7040 Series is supposed to ship by the end of the year, and there will be new unique features to the FW16 with the expansion bay and input modules. Let me know if I should place these files in a different folder structure with that in mind. See #773

Description of changes

• Added new configuration for Framework Laptop 13 AMD Ryzen 7040 Series. This shares some common configuration with the other Framework laptops around core shared components, though since this is the first AMD based Framework laptop there are other common modules for import and other options that are slightly different. Namely:
  • Prefer PPD over TLP for compatibility
  • nvme.noacpi=1 kernel param causes issues with standby (cannot log back in after suspending)
  • Do not include the fw-ectool package - the ectool will likely have to be packaged differently somehow (?) since it's using a different code branch of ChromeOS EC than the Intel based Framework laptops: https://community.frame.work/t/what-ec-is-used/38574/2
• Best kernel version to select is not locked in as of yet, but likely prefer kernel_latest due to amdgpu driver updates. Other recommended distros at launch are Fedora 39 Beta and Ubuntu 23.04 with some changes required.

Things done

• Tested the changes in your own NixOS Configuration
• Tested the changes end-to-end by using your fork of nixos-hardware and
  importing it via <nixos-hardware> or Flake input

[leona-ya]

Maybe something along the line of framework/13-inch/amd-7040 would make sense as a future file structure?

[nodu]

Keep the old paths/exposures and recreate all in the new structure? Then the old ones are still available and then new users can use the newly exposed paths?

…

On Wed, Nov 1, 2023, 8:13 AM Leona Maroni ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#765 (comment)>: > @@ -132,6 +132,7 @@ See code for all available configurations. | [Framework 11th Gen Intel Core](framework) | `<nixos-hardware/framework>` | | [Framework 12th Gen Intel Core](framework/12th-gen-intel) | `<nixos-hardware/framework/12th-gen-intel>` | | [Framework 13th Gen Intel Core](framework/13th-gen-intel) | `<nixos-hardware/framework/13th-gen-intel>` | +| [Framework AMD Ryzen 7040 Series](framework/7040-amd) | `<nixos-hardware/framework/7040-amd>` | I totally agree. Are there any possibilities to restructure the directory structure (I think there is not "the solution" so far)? Maybe backwards comptability for some time and add a warning? I think it would be confusing if only the 13 inch AMD model has a 13 inch path and the others only have the old paths. — Reply to this email directly, view it on GitHub <#765 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4NGI3FR2I2HJ4JX3IMVITYCJRKXAVCNFSM6AAAAAA6OZBYPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBYGQZTMNJVGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[reedriley]

Is there anything blocking landing this? I've been running NixOS with it on my 7840U from Framework successfully for about a week now.

[Mic92]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b689465