asus-zephyrus-ga402: remove unused kernel parameter #625
Conversation
|
@K900 can you check this too? |
|
We should probably force the latest kernel then. |
|
Maybe check for a lower kernel bound: #627 (comment) |
done using comments from @Mic92 (Thanks !) |
|
I will have a look on how to satisfy the unit tests with this, maybe I'll make the latest kernel the new default. |
aacebedo
force-pushed
the
aacebedo/ga502_clean_kernel_parameter
branch
from
1e254aa to
1f92439
Compare
fixed the missing config parameter inn the derivation |
Ok the problem is now the same as for MR #627. Wonder if we can change the kernel version used in the test or at least mock it. |
|
I certainly don't use this kernel param on my ga402 and I don't have any issues AFAICT. |
|
@mergify queue |
❌ Pull request must be rebased manuallyThe pull request can't be rebased without conflict and must be rebased manually |
|
@mergify queue |
❌ Pull request must be rebased manuallyThe pull request can't be rebased without conflict and must be rebased manually |
|
@mergify rebase |
✅ Branch has been successfully rebased |
Mic92
force-pushed
the
aacebedo/ga502_clean_kernel_parameter
branch
from
1f92439 to
938f54b
Compare
|
@mergify queue |
❌ Pull request must be rebased manuallyThe pull request can't be rebased without conflict and must be rebased manually |
|
@mergify rebase |
✅ Branch has been successfully rebased |
Mic92
force-pushed
the
aacebedo/ga502_clean_kernel_parameter
branch
from
938f54b to
dc8b25a
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at cb4dc98 |
Description of changes
Removes a flag not required anymore
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input