Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slimbook/hero: Init #1282

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Slimbook/hero: Init #1282

merged 1 commit into from
Jan 7, 2025

Conversation

LucasFA
Copy link
Contributor

@LucasFA LucasFA commented Dec 20, 2024

Description of changes

Create a profile for the Slimbook "HERO" model.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input
    I have tested with nix run ./test#run, as well.
Obsolete error: Please note that I have commented out the imports from `common/cpu/intel` and `common/gpu/intel/coffee-lake`, as they call `common/gpu/intel` and produces the following error during the build:
> sudo nixos-rebuild switch --flake .
building the system configuration...
error:
       … while calling the 'head' builtin
         at /nix/store/wj2qla569hnxwqfc26imv5hqbxc1rc27-source/lib/attrsets.nix:1574:11:
         1573|         || pred here (elemAt values 1) (head values) then
         1574|           head values
             |           ^
         1575|         elsewhile evaluating the attribute 'value'
         at /nix/store/wj2qla569hnxwqfc26imv5hqbxc1rc27-source/lib/modules.nix:816:9:
          815|     in warnDeprecation opt //
          816|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          817|         inherit (res.defsFinal') highestPrio;

while evaluating the option `system.build.toplevel':

       … while evaluating definitions from `/nix/store/wj2qla569hnxwqfc26imv5hqbxc1rc27-source/nixos/modules/system/activation/top-level.nix':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: The option `hardware.intelgpu.driver' in `/nix/store/6wricnap2cb90nj7kxi7kjxanczqp5ix-source/common/gpu/intel' is already declared in `/nix/store/4b7i72pprx6d2614bfpz4v0dnb12nlhp-source/common/gpu/intel'.

I am still pretty unfamiliar with Nix and NixOS, so I haven't managed to diagnose it yet. I would appreciate any feedback there.
If it is any use, my config is hosted in github.com/LucasFA/.nixos

Edit: I am happy to report that this error was just an error in my config. I have now tested the full version in my system.

Edit 26/12: I have been daily driving this the last few days. Doesn't seem to have any major issues except when a blank screen is triggered from the power settings inactivity period, which I have found no solution to.

@LucasFA LucasFA marked this pull request as draft December 21, 2024 16:02
@LucasFA LucasFA marked this pull request as ready for review December 26, 2024 11:40
@Mic92
Copy link
Member

Mic92 commented Jan 7, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Jan 7, 2025

queue

🛑 The pull request has been removed from the queue default

The pull request conflicts with at least one pull request ahead in queue.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Jan 7, 2025

queue

🛑 The pull request has been removed from the queue default

The pull request #1282 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Jan 7, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4c5c3be

mergify bot added a commit that referenced this pull request Jan 7, 2025
@mergify mergify bot merged commit 4c5c3be into NixOS:master Jan 7, 2025
3 checks passed
@LucasFA LucasFA deleted the slimbook_hero branch January 7, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants