Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++20 compilation with clang #7733

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Fix C++20 compilation with clang #7733

merged 2 commits into from
Feb 1, 2023

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Feb 1, 2023

Motivation

Followup to #7203.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

@edolstra edolstra requested a review from thufschmitt as a code owner February 1, 2023 19:35
@edolstra edolstra enabled auto-merge February 1, 2023 19:38
@edolstra edolstra merged commit 119ba50 into NixOS:master Feb 1, 2023
@edolstra edolstra deleted the clang-c++20 branch February 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edolstra