non-critical-infra: init jitsi #404
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets up jitsi for the nixos-org. The jitsi config has the lobby enabled for every-room by-default, this means only people that get access will be able to join. Access control is done using the `Secure Domain Lobby Bypass` plugin and should be changed to `Token Lobby Bypass` once we have a IDP.
|
ref #401 |
Can you maybe send that as a separate PR ahead of time? Do we know on which machine we're deploying this at this point? (caliban?) |
delroth
reviewed
Apr 14, 2024
| @@ -9,6 +9,7 @@ | |||
| ../../modules/first-time-contribution-tagger.nix | |||
| ../../modules/backup.nix | |||
| ../../modules/vaultwarden.nix | |||
| ../../modules/jitsi.nix | |||
There was a problem hiding this comment.
Oh, looks like it's already not. Bleh.
So instead: can you sort this? :P (the ../../modules/* entries)
Erethon
reviewed
Apr 18, 2024
| autoKnock = true; | ||
| enableChat = false; | ||
| }; | ||
| stunServers = [ |
There was a problem hiding this comment.
This should be p2p.stunServers according to the documentation and code.
An alternative to using (and depending on) the matrix.org TURN server would be to disable the p2p calls for two person calls completely with p2p.enabled = false. One could argue this is a bit more privacy friendly, since this way you never expose your IP to the other person on the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config still contains a bug where lobby-autostart kicks the moderator after joining using the secure domain bypass
The jitsi config has the lobby enabled for every-room by-default, this means only people that get access will be able to join. Access control is done using the
Secure Domain Lobby Bypassplugin and should be changed toToken Lobby Bypassonce we have a IDP.Adding users for Secure Domain Lobby Bypass has to be done in a imperativ way using:
Depends on nixos/nixpkgs#297809
And the DNS records are still missing from the pr.