Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL & Autocrafting! #399

Open
wants to merge 80 commits into
base: AE2-RV6
Choose a base branch
from
Open

QOL & Autocrafting! #399

wants to merge 80 commits into from

Conversation

811Alex
Copy link

@811Alex 811Alex commented Feb 9, 2021

This PR has some quality of life changes for the arcane terminal, making it craft amounts like a normal ME terminal would (fixes an issue that made you craft too many items when clicking a bit fast) and makes the vis crystals always go in the right slots, when clicking the + button in JEI.

In addition, it adds autocrafting! I got some ideas from 1.7.10, but this is a rewrite and works a little bit differently. It includes the recipes and the research for the new things as well.

Lastly, it includes some nice changes from other forks.
Any new resources I added are CC0.

@BrockWS BrockWS self-assigned this Feb 11, 2021
@BrockWS BrockWS self-requested a review February 11, 2021 10:26
811Alex added 25 commits July 4, 2021 20:27
Note: this also makes some minor changes to how the busses function and adds handler caching to the storage bus.
Couple of notes: EssentiaContainerAdapter's injectItems() now checks canAccept() too
and I made report inaccessible items be related to read access since I don't understand it's actual purpose in base AE2 busses
To make sure we look for the TE in the right world.
so now the result's tooltip doesn't get nuked \o/
This is mainly to completely avoid instantiating integration classes of mods that might not exist on runtime.
hwyla is confused about the <br> tag
startJob() runs on the server thread already, no need for packets
uses TOP's localization tags instead, since TOP adds the text on the server-side
and migrates the Arcane Assembler status text to LangKeys
@811Alex
Copy link
Author

811Alex commented Jul 13, 2021

Added many more fixes and improvements, most importantly the rest of the missing settings/buttons to our parts.

@ByThePowerOfScience
Copy link

ByThePowerOfScience commented Mar 15, 2022

There is an issue with the Arcane Crafting Terminal causing very high latency when attempting to craft with a large ME system, to the point where I can craft something, exit the terminal, walk across three chunks, right-click a chest, and still have about 10 seconds before the chest opens, assuming the "connection closed by remote host" error doesn't occur.

Does this PR address that issue?
(this is also an excuse to bump this PR because it's been too long)

@811Alex
Copy link
Author

811Alex commented Mar 15, 2022

I don't think I ever tried to address anything like that specifically, so doubtful. If this is an issue that happens without the code of this PR (latest official release) and does not happen on a regular AE2 terminal, feel free to make an issue on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants