clean up

Nirma · Jun 13, 2019 · 692b412 · 692b412
1 parent 4dde97e
commit 692b412
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/Sources/UIDeviceExtensions.swift b/Sources/UIDeviceExtensions.swift
@@ -65,10 +65,6 @@ public extension UIDeviceComplete where Base == UIDevice {
     var isSimulator: Bool {
         return deviceFamily == .simulator
     }
-
-    var hasNotch: Bool {
-        return deviceModel.hasNotch
-    }
 }
 
 

diff --git a/Tests/DeviceModelTests.swift b/Tests/DeviceModelTests.swift
@@ -311,5 +311,14 @@ class DeviceModelTests: XCTestCase {
 
         XCTAssert(deviceModel == .unknown , "DeviceModel - .unknown is failing")
     }
-
+
+    // MARK: Notch test
+    func testHasNotch() {
+      let notchModels: [DeviceModel] = [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR]
+
+      let noNotchModels: [DeviceModel] = DeviceModel.allCases.filter( { !notchModels.contains($0) })
+
+      notchModels.forEach { XCTAssertTrue($0.hasNotch) }
+      noNotchModels.forEach { XCTAssertFalse($0.hasNotch) }
+    }
 }
diff --git a/Tests/UIDeviceExtensionsTests.swift b/Tests/UIDeviceExtensionsTests.swift
@@ -55,14 +55,4 @@ class UIDeviceExtensionsTests: XCTestCase {
         let deviceFamily = DeviceFamily(rawValue: "x86_64")
         XCTAssert(deviceFamily == .simulator, "DeviceExtensions - .isSimulator is failing")
     }
-
-
-    func testHasNotch() {
-      let notchModels: [DeviceModel] = [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR]
-
-      let noNotchModels: [DeviceModel] = DeviceModel.allCases.filter( { !notchModels.contains($0) })
-
-      notchModels.forEach { XCTAssertTrue($0.hasNotch) }
-      noNotchModels.forEach { XCTAssertFalse($0.hasNotch) }
-    }
 }