Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protobuf files and wasm client #46

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

pablojhl
Copy link
Member

No description provided.

@pablojhl pablojhl requested a review from tim-hm December 10, 2024 08:16
Copy link

github-actions bot commented Dec 10, 2024

Coverage Report for ./client-vms

Status Category Percentage Covered / Total
🔵 Lines 88.25% 2051 / 2324
🔵 Statements 88.25% 2051 / 2324
🔵 Functions 80.93% 208 / 257
🔵 Branches 93.76% 361 / 385
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
client-vms/src/gen-proto/nillion/membership/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/membership/v1/version_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/balance_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/config_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/quote_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/receipt_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/preprocessing/v1/element_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/preprocessing/v1/generate_pb.ts 0% 0% 0% 0% 1-172
client-vms/src/vm/operation/store-values.ts 93.57% 96.42% 87.5% 93.57% 92-97, 181-183
Generated in workflow #66 for commit 834908c by the Vitest Coverage Report Action

Copy link
Collaborator

@tim-hm tim-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pablojhl, a few bits from me:

  • When bumping the wasm artefact I've been isolating that change to a single commit like here and including build details in commit-sha.txt. This really just a workaround until the nilvm repo is open source but its helpful if/when we need to bisect problems.
  • I've re-run the pipeline and ran it locally, but with this commit tests are now failing.

Lemme know if you need assistance with any of that!

@pablojhl
Copy link
Member Author

pablojhl commented Dec 10, 2024

  • When bumping the wasm artefact I've been isolating that change to a single commit like here and including build details in commit-sha.txt. This really just a workaround until the nilvm repo is open source but its helpful if/when we need to bisect problems.
  • I've re-run the pipeline and ran it locally, but with this commit tests are now failing.

My fault, I should create it as a draft until the needed changes are merged into the nilvm repo. I tested the commit locally running the nillion-devnet from the branch that contains the changes are pending to merge and the tests are working fine. Anyway, I'm going to update the PR to draft until they are merged.

Sorry for the inconvenience.

@pablojhl pablojhl marked this pull request as draft December 10, 2024 11:10
@tim-hm
Copy link
Collaborator

tim-hm commented Dec 10, 2024

Ahh that makes more sense!

@pablojhl pablojhl marked this pull request as ready for review December 13, 2024 10:24
@pablojhl pablojhl requested a review from tim-hm December 13, 2024 10:24
@pablojhl pablojhl force-pushed the chore/update-wasm-and-proto branch from dfa9b70 to 7383ab8 Compare December 16, 2024 17:29
Copy link
Collaborator

@tim-hm tim-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ya, looks good! Some suggestions from me:

  • Its not immediately clear that chore: remove particles is also a wasm package bump ... might be worth making that distinction but not a show stopper by any stretch
  • Given the updated protobuf files (and assuming you're looking to release and updated npm package?), I would also bump the client-vm PATCH

@pablojhl
Copy link
Member Author

Hi ya, looks good! Some suggestions from me:

  • Its not immediately clear that chore: remove particles is also a wasm package bump ... might be worth making that distinction but not a show stopper by any stretch
  • Given the updated protobuf files (and assuming you're looking to release and updated npm package?), I would also bump the client-vm PATCH

Regarding the first point, do you mean adding a comment in the PR?

@pablojhl pablojhl merged commit c4b13b0 into main Dec 17, 2024
2 checks passed
@pablojhl pablojhl deleted the chore/update-wasm-and-proto branch December 17, 2024 08:32
@pablojhl pablojhl linked an issue Dec 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signatures in ts-client
2 participants