-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update protobuf files and wasm client #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pablojhl, a few bits from me:
- When bumping the wasm artefact I've been isolating that change to a single commit like here and including build details in commit-sha.txt. This really just a workaround until the nilvm repo is open source but its helpful if/when we need to bisect problems.
- I've re-run the pipeline and ran it locally, but with this commit tests are now failing.
Lemme know if you need assistance with any of that!
My fault, I should create it as a draft until the needed changes are merged into the nilvm repo. I tested the commit locally running the nillion-devnet from the branch that contains the changes are pending to merge and the tests are working fine. Anyway, I'm going to update the PR to draft until they are merged. Sorry for the inconvenience. |
Ahh that makes more sense! |
dfa9b70
to
7383ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ya, looks good! Some suggestions from me:
- Its not immediately clear that
chore: remove particles
is also a wasm package bump ... might be worth making that distinction but not a show stopper by any stretch - Given the updated protobuf files (and assuming you're looking to release and updated npm package?), I would also bump the client-vm PATCH
Regarding the first point, do you mean adding a comment in the PR? |
No description provided.