-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: various fixes and refinements #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- payments: add `PaymentError` and fail if unhandled exception encountered - fix: broken tests due to change error message - core: add `TaggedError` interface to core This is an initial attempt at improving the error DX, and if it goes well, I will start to update other parts of the system to follow.
tim-hm
force-pushed
the
feat/fixes-and-refinements
branch
2 times, most recently
from
August 1, 2024 17:50
456123c
to
e3120ae
Compare
The consuming app should choose to include (or not) react dev tools.
The previous `NOUN-ADJECTIVE` naming was used as an experiment to see if it improved IDE autocomplete, however, it made autocomplete feel clunky and unintuitive.
Prefer to reader text wrapping.
Its rare for apps to use Uint8Array directly so `SecretString` uses Nada's `SecretBlob` (`Uint8Array`) under the hood whilst exposing a ergonomic `SecretString` to users.
tim-hm
force-pushed
the
feat/fixes-and-refinements
branch
from
August 1, 2024 21:22
e3120ae
to
d941568
Compare
This has only been verified with `npm run dev`; building for production tbc.
- flatten snippets to dist folder - add basic logging in worker - separate worker creation into start-worker.js and behaviour into worker.js
The "dist" folder needs to be explicitly included for `npm publish` to create a complete (eg working) package.
This also renames package output to index.mjs to communicate clearly its esm.
tim-hm
force-pushed
the
feat/fixes-and-refinements
branch
from
August 2, 2024 15:05
d941568
to
931db06
Compare
tim-hm
force-pushed
the
feat/fixes-and-refinements
branch
from
August 2, 2024 15:27
29dfbe1
to
3d1a932
Compare
tim-hm
force-pushed
the
feat/fixes-and-refinements
branch
from
August 2, 2024 15:33
3d1a932
to
5bbcb01
Compare
tim-hm
force-pushed
the
feat/fixes-and-refinements
branch
from
August 2, 2024 15:37
5bbcb01
to
234ab25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.