Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: various fixes and refinements #2

Merged
merged 20 commits into from
Aug 2, 2024
Merged

Conversation

tim-hm
Copy link
Collaborator

@tim-hm tim-hm commented Aug 1, 2024

No description provided.

- payments: add `PaymentError` and fail if unhandled exception encountered
- fix: broken tests due to change error message
- core: add `TaggedError` interface to core

This is an initial attempt at improving the error DX, and if it goes well, I will start to update other parts of the system to follow.
@tim-hm tim-hm force-pushed the feat/fixes-and-refinements branch 2 times, most recently from 456123c to e3120ae Compare August 1, 2024 17:50
tim-hm added 7 commits August 1, 2024 17:21
The consuming app should choose to include (or not) react dev tools.
The previous `NOUN-ADJECTIVE` naming was used as an experiment to see if it improved IDE autocomplete, however, it made autocomplete feel clunky and unintuitive.
Prefer to reader text wrapping.
Its rare for apps to use Uint8Array directly so `SecretString` uses Nada's `SecretBlob` (`Uint8Array`) under the hood whilst exposing a ergonomic `SecretString` to users.
@tim-hm tim-hm force-pushed the feat/fixes-and-refinements branch from e3120ae to d941568 Compare August 1, 2024 21:22
tim-hm added 10 commits August 2, 2024 10:56
This has only been verified with `npm run dev`; building for production tbc.
- flatten snippets to dist folder
- add basic logging in worker
- separate worker creation into start-worker.js and behaviour into worker.js
The "dist" folder needs to be explicitly included for `npm publish` to create a complete (eg working) package.
This also renames package output to index.mjs to communicate clearly its esm.
@tim-hm tim-hm force-pushed the feat/fixes-and-refinements branch from d941568 to 931db06 Compare August 2, 2024 15:05
@tim-hm tim-hm force-pushed the feat/fixes-and-refinements branch from 29dfbe1 to 3d1a932 Compare August 2, 2024 15:27
@tim-hm tim-hm force-pushed the feat/fixes-and-refinements branch from 3d1a932 to 5bbcb01 Compare August 2, 2024 15:33
@tim-hm tim-hm force-pushed the feat/fixes-and-refinements branch from 5bbcb01 to 234ab25 Compare August 2, 2024 15:37
@tim-hm tim-hm marked this pull request as ready for review August 2, 2024 15:41
@tim-hm tim-hm merged commit cc79090 into main Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant