Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE YET!!! #106

Open
wants to merge 10 commits into
base: Milwaukee
Choose a base branch
from
Open

DO NOT MERGE YET!!! #106

wants to merge 10 commits into from

Conversation

Noah-Kennedy
Copy link
Member

Completes #Story Issue Number

Tests Run On:

  • Test Bench
  • Robot Prototype
  • Final Robot

For Reviewers

Here are some things to look for:

  • Comments in the code.
    • Comments explain why the code is doing something, not what or how.
  • No "magic numbers" or hard coded constants.
  • Small code change (i.e. 10-15 lines or so)
  • The code implements the design specified in the corresponding story.
  • The code interfaces with other code and hardware properly.
    • Ex. Code implementing a command for one subsystem should not affect another subsystem.
    • Ex. Objects representing hardware on the robot should only be accessed in a subsystem.
    • Ex. Joysticks should only be accessed in setting up buttons or in commands (not subsystems).

@Noah-Kennedy
@NicoletFEAR/mentors

Noah-Kennedy and others added 9 commits March 11, 2017 17:55
@Noah-Kennedy
End of Friday. Stuff either doesn't work or does infinite spin.
3bd5435
@Noah-Kennedy
Vision works, whether it is turning in the right direction is somewhat
65f2162 
inconsistent. It is turning in response to seeing the tape and driving
forward
@Noah-Kennedy
Tried and failed to add working distance stop conditions.
8d4e6e9
Fixed getWhereCameraIsPointing()
f8773e0 
Should return "Center" when it is appropriate. Not tested.
Attempted to fix DriveToLeftGearPeg()
7c91b7d
@Noah-Kennedy
Attempted to fix DriveToLeftGearPeg()
6e5e664
Commented out DriveToPosition() in left and right gear peg autonomous
09dc35c 
Tested the DriveArcSpeed() in left and right gear peg auto, works
consistently even after wifi and power reconnections
Left and right gear peg auto tuned to the correct distances,
4a75584 
teleopInit() switches the front side
@Noah-Kennedy
10:33 Thursday Milwaukee -> Commented out some stuff
4440341 
Commented out an unused command and removed the VisionAlignWithPeg
command from the sendableChooser.
@Noah-Kennedy
Milwaukee Thursday 10:44 -> Made Tweaks Before Merge
23b19df 
Tweaked several constants before a merge.
@Noah-Kennedy Noah-Kennedy changed the title Vision before milwaukee DO NOT MERGE YET!!! Mar 23, 2017
@jkoritzinsky jkoritzinsky removed their request for review March 2, 2018 20:28
@jkoritzinsky jkoritzinsky reopened this Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noah-Kennedy @jkoritzinsky