Fix file copying on Windows and installation by rules.txt #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where, on Windows, dircpy's method of file copying happens too slow and the task dispatch kills the thread before the file copy finishes. (At least, that's my best guess for what's happening) Rather than shelling out the copy calls, it runs a synchronous operation.
Also fixes an issue where mods could not be installed by rules.txt because anything without a
zipor7zextension got eaten by previous if cases. I'm rolling this into the same PR because I accidentally rolled them into the same commit, and had previously kept the bug around specifically as a workaround for the file copying issue.Doesn't add
*.txtto the installation selection dialogue. Need to find time to figure out how to do that, but wanted to get this up because I rolled it into my side-0.15.0 and didn't want 0.15.1 to regress if you found time to do a release before I could find it.Addresses, closes #207