Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to Symlink deployment for cemu detection #203

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

GingerAvalanche
Copy link
Collaborator

Tiny change. The default behavior for emulators should probably be to symlink, barring non-standard setups.

@NiceneNerd
Copy link
Owner

The main (only?) reason symlinks are not already default in this case is because they're weird on Windows, as it can either only use a directory junction (non-admin, but only works on internal drives) or else requires admin permissions for a real symlink (unless you enable developer mode). Since these are both fairly obnoxious caveats, I'm not sure about using it as a default.

@GingerAvalanche
Copy link
Collaborator Author

GingerAvalanche commented Aug 7, 2024

Surely it's less annoying to request admin permissions once per external symlink than it would be to force everyone on windows to wait twice as long for the copy to take place, every time?

Vortex already requests admin permissions every single time you deploy (never bothering to try using junctions), and I've never noticed people having a problem with that. I think Mod Organizer is the same.

Maybe it'd be a better idea to just only use junctions internally on Windows, and then catch the resulting "wrong function" error for external links with a message to the user that they need to switch to copy for their setup. Or not run their emulator over an incredibly slow USB transfer interface.

@NiceneNerd
Copy link
Owner

Let's do it. Junctions will probably work over 80% of the time anyway.

@NiceneNerd NiceneNerd merged commit 8e77fb7 into NiceneNerd:master Aug 12, 2024
10 checks passed
@GingerAvalanche GingerAvalanche deleted the cemu-detect-symlink branch August 12, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants