inv-126 : 타이틀, 내용 업데이트 쿼리 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/components/editor/title-input.tsx
xilucks
requested review from
bepyan,
WooWan,
delphox60 and
9keyyyy
as code owners
bepyan
reviewed
Aug 17, 2024
src/components/editor/navigation.tsx
Outdated
| // TODO: API insert page | ||
| // TODO: API log notification | ||
| await updateInvitation({ | ||
| id: subDomain, |
There was a problem hiding this comment.
subDomain은 수정이 가능하기에, editor.config.invitationId로 적용해주세요1
bepyan
reviewed
Aug 17, 2024
| } | ||
|
|
||
| export async function createInvitation( | ||
| params: CreateInvitationParams, | ||
| ): Promise<InvitationInsert> { | ||
| const id = nanoid(); | ||
| const currentTimestamp = new Date(); | ||
| const sessionId = await getAuth(); |
There was a problem hiding this comment.
const auth = await getAuth() 컨벤션 맞춰주시면 감사하겠습니다 🙇🏻♂️
bepyan
reviewed
Aug 17, 2024
| @@ -49,9 +46,9 @@ export default function TitleInput() { | |||
| if (signal.aborted) { | |||
| return; | |||
| } | |||
| editorConfig.invitationTitle = value; | |||
| editor.config.invitationTitle = value; | |||
There was a problem hiding this comment.
await delay(1000); 비워주시고 api 요청 완료시에 UPDATE_CONFIG action으로 상태 동기화 해주세용.
bepyan
reviewed
Aug 17, 2024
src/components/editor/navigation.tsx
Outdated
| customFields: content, | ||
| id: editor.config.invitationId, | ||
| title: editor.config.invitationTitle, | ||
| customFields: content as Record<string, any>, |
There was a problem hiding this comment.
기존 content는 로깅을 위해서 stringify한 것이기에 editor.data를 customFields로 요청해주세요.
bepyan
reviewed
Aug 17, 2024
|
|
||
| editor.config.invitationTitle = value; | ||
| await updateInvitation({ | ||
| id: editor.config.invitationSubdomain, |
There was a problem hiding this comment.
요거 invitationSubdomain이 아닌 invitationId로 해주세요!
|
The latest updates on your projects.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
타이틀, 내용 업데이트가 가능해요.