inv-54 참석 여부 조회 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2024 21:13
9keyyyy
requested review from
bepyan,
xilucks,
WooWan and
delphox60
as code owners
bepyan
approved these changes
Jul 22, 2024
Comment on lines
+33
to
+34
| queryKey: ["invitationResponseStats"], | ||
| queryFn: () => getInvitationResponseStats(), |
There was a problem hiding this comment.
음 이상하다 이건 서버 사이드에서 prefetch 안해도 괜찮나?
잘 동작하면 이 코멘트 무시해 주세요.
Comment on lines
23
to
30
| const result = await db | ||
| .select({ | ||
| totalResponses: sql`COUNT(*)`.as("total_responses"), | ||
| attendingCount: | ||
| sql`SUM(CASE WHEN ${invitationResponses.attendance} = true THEN 1 ELSE 0 END)`.as( | ||
| "attending_count", | ||
| ), | ||
| }) |
There was a problem hiding this comment.
sql을 깡통으로 쓰기 보단 drizzle ORM이 제공해주는 helper를 활용하면,
더 안전하고 가독성이 좋을 것 같은데 한번 검토해 봐주세요!
sql을 쓰는게 편하다면 지금도 좋습니다~!
https://orm.drizzle.team/learn/guides/count-rows
https://orm.drizzle.team/docs/select#aggregations-helpers
WooWan
reviewed
Jul 22, 2024
Comment on lines
10
to
37
| export async function getAllInvitationResponses() { | ||
| return await db.select().from(invitationResponses); | ||
| } | ||
|
|
||
| export async function getInvitationResponseById(id: InvitationResponse["id"]) { | ||
| const responses = await db | ||
| .select() | ||
| .from(invitationResponses) | ||
| .where(eq(invitationResponses.id, id)); | ||
| return responses[0]; | ||
| } | ||
|
|
||
| export async function getInvitationResponseStats() { | ||
| const result = await db | ||
| .select({ | ||
| totalResponses: sql`COUNT(*)`.as("total_responses"), | ||
| attendingCount: | ||
| sql`SUM(CASE WHEN ${invitationResponses.attendance} = true THEN 1 ELSE 0 END)`.as( | ||
| "attending_count", | ||
| ), | ||
| }) | ||
| .from(invitationResponses); | ||
|
|
||
| return { | ||
| totalResponses: Number(result[0].totalResponses), | ||
| attendingCount: Number(result[0].attendingCount), | ||
| }; | ||
| } |
There was a problem hiding this comment.
JavaScript는 외부 리소스를 접근할 때 try catch를 감싸주어야 합니다
익숙치 않으시면 제가 나중에 감싸놓을게요 🐝
There was a problem hiding this comment.
일단 액션 호출하는 단(클라이언트 단)에서 try catch 묶어도 되니 추후 개선으로 가도 될 것 같아요
There was a problem hiding this comment.
앗 넵넵! 화요일에 창완오빠랑도 클라이언트 단에서 처리하는 것으로 이야기했습니당
|
TypeScript도 낯설텐데 프론트까지.. 국희님께 프론트엔드 배우러 가겠습니ㄷ..r |
|
오예 고생하셨습니다 LGTM |
xilucks
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
아래 항목 확인할 수 있는 쿼리 작성하였습니다.
playground/invitation-response에서 확인 가능합니다. (neon dev branch 사용)