inv-83 엘리먼트 > 컨테이너 > 레이아웃 설정 > 마크업 구현 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bepyan
requested review from
xilucks,
WooWan,
delphox60 and
9keyyyy
as code owners
|
The latest updates on your projects.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
레이아웃 설정 부분 마크업을 구현했습니다.
피그마랑 똑같이 만들다가 상태 연동할 생각하니 뇌정지가 와서 (align-items, justify-content) 부분은 추후 개선합시다..
공유사항
sidebar-element-settings-tab.tsx → sidebar-element-settings-tab/index.tsx
사이드바 엘리먼트 설정 탭은 앞으로 많이 복잡해질 예정이기에 별도 디랙토리를 만들었습니다.
하위로 이런 저런 설정 컴포넌트를 추가하면 될 것 같아요.
ex. advance-settings, image-settings
editor/ui에디터만의 ui 컴포넌트가 필요할 수 있는데 editor/ui에 넣었습니다.
스크린샷
2024-08-09.17.47.24.mov