Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Piano Key Morph #1489

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Updating Piano Key Morph #1489

wants to merge 7 commits into from

Conversation

ebiwonjumit
Copy link

Expanded range of PianoKeyMorph and changed the labels.

@dragazo
Copy link

dragazo commented Dec 19, 2023

You'll need to revert the update of the cloud submodule. And we'll probably still need to figure out how different octaves are going to be picked. It looks like so far this just updates the display names. I was imagining we'd have a second row of octaves the shows up either above or below the keyboard and users can pick the octave that way. Then we would only need to show buttons spanning a single octave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants