Retriable client #195
Retriable client #195
Conversation
taco-paco
force-pushed
the
feat/horizontal/state-reconstruction
branch
from
4a88782 to
a89ee2a
Compare
taco-paco
force-pushed
the
feat/horizontal/retriable-client
branch
from
3698e90 to
8b0d2e6
Compare
taco-paco
force-pushed
the
feat/horizontal/state-reconstruction
branch
from
019668b to
53476e0
Compare
taco-paco
force-pushed
the
feat/horizontal/retriable-client
branch
from
8b0d2e6 to
fa24151
Compare
|
you can fix taplo by running |
| tracing.workspace = true | ||
| tracing-subscriber.workspace = true | ||
| uuid.workspace = true | ||
|
|
||
| lambda_runtime = "0.13.0" | ||
| lambda_http = "0.13.0" |
There was a problem hiding this comment.
move this to the root Cargo.toml as well
There was a problem hiding this comment.
That's needed only in lambda level
| time: &DateTime<Utc>, | ||
| exclusive_start_key: &Option<HashMap<String, AttributeValue>>, | ||
| ) -> Result<ScanOutput, DBScanError> { | ||
| const MAX_CAPACITY: usize = 100; |
There was a problem hiding this comment.
| const MAX_CAPACITY: usize = 100; | |
| const MAX_CAPACITY: i32 = 100; |
wdyt?
There was a problem hiding this comment.
Everything associated with array size, capacity, indexes shall be usize
| #[derive(Default)] | ||
| pub enum DynamoDBAction { | ||
| #[default] | ||
| Default, |
There was a problem hiding this comment.
Just curious: why do we need the default field here?
There was a problem hiding this comment.
Because of borrow checker in Retrier::resend_pending_actions algorithm, which is pretty much Vec::retain. Because. We need to take ownership of action to extract oneshot::sender, but we can't since its within an array we reference, so we replace is with Default.
All defaults at the end will wether be overridden or truncated
taco-paco
force-pushed
the
feat/horizontal/state-reconstruction
branch
from
53476e0 to
a18a661
Compare
taco-paco
force-pushed
the
feat/horizontal/retriable-client
branch
from
8f04023 to
57630f6
Compare
taco-paco
changed the base branch from
feat/horizontal/state-reconstruction
to
feat/horizontal/main
Retriable clients, to keep from failing on connection errors.