Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Implementation of periodic purging #181

Merged
merged 9 commits into from
Sep 25, 2024

Conversation

taco-paco
Copy link
Contributor

No description provided.

@taco-paco taco-paco requested a review from varex83 September 11, 2024 04:50
@stranger80 stranger80 added this to the 0.7 milestone Sep 12, 2024
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, try to avoid unwrap as much as you can, and use Result<...>

crates/types/Cargo.toml Show resolved Hide resolved
crates/worker/src/clients/s3_client.rs Outdated Show resolved Hide resolved
crates/worker/src/commands/utils.rs Outdated Show resolved Hide resolved
crates/worker/src/commands/utils.rs Show resolved Hide resolved
crates/worker/src/purgatory.rs Show resolved Hide resolved
crates/worker/src/purgatory.rs Outdated Show resolved Hide resolved
crates/worker/src/purgatory.rs Show resolved Hide resolved
crates/worker/src/worker.rs Show resolved Hide resolved
crates/worker/src/purgatory.rs Outdated Show resolved Hide resolved
crates/worker/src/worker.rs Show resolved Hide resolved
crates/worker/src/purgatory.rs Outdated Show resolved Hide resolved
@taco-paco taco-paco force-pushed the feat/horizontal/purgatory branch from 863f20a to 3e12648 Compare September 18, 2024 05:20
@taco-paco taco-paco force-pushed the feat/horizontal/purgatory branch from 3e12648 to cbde110 Compare September 18, 2024 06:08
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varex83
Copy link
Contributor

varex83 commented Sep 19, 2024

can you fix the CI please?

@taco-paco
Copy link
Contributor Author

can you fix the CI please?

Fixed ones that are related. Pushed to rretriable clients pr since some of the things are already fixed there

@taco-paco taco-paco merged commit 40856d9 into feat/horizontal/main Sep 25, 2024
2 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants