This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varex83
suggested changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, try to avoid unwrap
as much as you can, and use Result<...>
varex83
suggested changes
Sep 12, 2024
taco-paco
force-pushed
the
feat/horizontal/purgatory
branch
from
September 18, 2024 05:20
863f20a
to
3e12648
Compare
taco-paco
force-pushed
the
feat/horizontal/main
branch
from
September 18, 2024 06:06
0806d6e
to
41413ba
Compare
taco-paco
force-pushed
the
feat/horizontal/purgatory
branch
from
September 18, 2024 06:08
3e12648
to
cbde110
Compare
varex83
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can you fix the CI please? |
Fixed ones that are related. Pushed to rretriable clients pr since some of the things are already fixed there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.