Merge pull request #120 from NethermindEth/feature/notices-accordian

Move Background notices to new accordian
NethermindEth · Jun 25, 2024 · b97199c · b97199c
2 parents 8466144 + 77b7878
commit b97199c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/plugin/src/components/BackgroundNotices/index.tsx b/plugin/src/components/BackgroundNotices/index.tsx
@@ -18,7 +18,6 @@ const BackgroundNotices: React.FC = () => {
                 className="list-group-item d-flex justify-content-left align-items-center bg-notices-text bg-primary"
                 key={index}
               >
-                <span className="badge badge-information badge-pilled mr-2">{index + 1}</span>
                 {notice}
               </li>
             )

diff --git a/plugin/src/features/Plugin/index.tsx b/plugin/src/features/Plugin/index.tsx
@@ -16,9 +16,9 @@ import { hashDirAtom, compilationAtom } from '@/atoms'
 import { deploymentAtom } from '@/atoms/deployment'
 import { initializeRemixClient, isLoadedAtom, remixClientAtom } from '@/stores/remixClient'
 import storage from '@/utils/storage'
-import './styles.css'
 import useAsync from '@/hooks/useAsync'
 import { type AccordianTabs } from '@/types/common'
+import './styles.css'
 
 export const Plugin = () => {
   const { status: compileStatus, errorMessages: compileErrorMessages } = useAtomValue(compilationAtom)
@@ -147,10 +147,21 @@ export const Plugin = () => {
                   <TransactionHistory />
                 </AccordionContent>
               </AccordianItem>
+              <AccordianItem value="notices">
+                <AccordionTrigger
+                  onClick={() => {
+                    handleTabView('notices')
+                  }}
+                >
+                  <span className="d-flex align-items-center" style={{ gap: '0.5rem' }}>
+                    <p style={{ all: 'unset' }}>Notices</p>
+                  </span>
+                </AccordionTrigger>
+                <AccordionContent>
+                  <BackgroundNotices />
+                </AccordionContent>
+              </AccordianItem>
             </Accordian>
-            <div className="mt-5">
-              <BackgroundNotices />
-            </div>
           </div>
           <div>
             <Environment />

diff --git a/plugin/src/types/common.ts b/plugin/src/types/common.ts
@@ -1 +1 @@
-export type AccordianTabs = 'compile' | 'deploy' | 'interaction' | 'transactions' | ''
+export type AccordianTabs = 'compile' | 'deploy' | 'interaction' | 'transactions' | 'notices' | ''
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export type AccordianTabs = 'compile' \| 'deploy' \| 'interaction' \| 'transactions' \| ''
		export type AccordianTabs = 'compile' \| 'deploy' \| 'interaction' \| 'transactions' \| 'notices' \| ''