Thiagodeev/rpcv08 final changes #644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagodeev
force-pushed
the
thiagodeev/rpcv08-finalChanges
branch
from
4108a47
to
629890b
Compare
thiagodeev
force-pushed
the
thiagodeev/rpcv08-finalChanges
branch
from
629890b
to
b7ce944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#623
This PR aims to implement some RPC v0.8.0 updates to starknet.go. The ones addressed by this PR are:
Components
CONTRACT_EXECUTION_ERROR
EXECUTION_RESOURCES
COMPUTATION_RESOURCES (remotion)
Errors
CONTRACT_ERROR
TRANSACTION_EXECUTION_ERROR
Note: As the RPC v0.8.0 has not yet been released, we can't fully test these changes as the nodes haven't implemented them yet. They will be updated before merging into main
Also, it improves the RPCError type. Now we have a way of returning the error message contained in the Data error field. We can also access it just by checking if it's nil or not.