Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starknet abi forms #215

Merged
merged 19 commits into from
Dec 13, 2023
Merged

Starknet abi forms #215

merged 19 commits into from
Dec 13, 2023

Conversation

rjnrohit
Copy link
Contributor

@rjnrohit rjnrohit commented Dec 6, 2023

No description provided.

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-remix-plugin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:21am

Copy link

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

# Conflicts:
#	plugin/src/features/Deployment/index.tsx
#	plugin/src/hooks/useRemixClient.ts
Copy link
Contributor

@stranger80 stranger80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjnrohit rjnrohit merged commit d01b67e into develop Dec 13, 2023
4 checks passed
@rjnrohit rjnrohit deleted the starknet-abi-forms branch December 13, 2023 09:02
@rjnrohit rjnrohit restored the starknet-abi-forms branch December 13, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants