Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error processing for new cairo file #204

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fixed error processing for new cairo file #204

merged 3 commits into from
Nov 14, 2023

Conversation

stranger80
Copy link
Contributor

@stranger80 stranger80 commented Nov 11, 2023 •
edited
Loading

Fixes #201

@stranger80 stranger80 requested a review from varex83 November 11, 2023 15:43
@vercel Vercel
Copy link

vercel bot commented Nov 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-remix-plugin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 3:48am

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 11, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

rjnrohit
rjnrohit approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@rjnrohit rjnrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @stranger80 , lgtm

@rjnrohit rjnrohit merged commit 37906cc into develop Nov 14, 2023
3 checks passed
@rjnrohit rjnrohit deleted the feat/filenotfound-fix branch November 14, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjnrohit rjnrohit rjnrohit approved these changes

@varex83 varex83 Awaiting requested review from varex83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"File not found" during Cairo compilation
2 participants
@stranger80 @rjnrohit