Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix problem with logging #203

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix problem with logging #203

merged 1 commit into from
Nov 14, 2023

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Nov 10, 2023

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starknet-remix-plugin ✅ Ready (Inspect) Visit Preview Nov 10, 2023 10:01am

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 10, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

rjnrohit
rjnrohit approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@rjnrohit rjnrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjnrohit rjnrohit merged commit 77ea748 into develop Nov 14, 2023
3 checks passed
@rjnrohit rjnrohit deleted the fix/logs-problem branch November 14, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjnrohit rjnrohit rjnrohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varex83 @rjnrohit