Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement local Katana integration #190

Closed
wants to merge 6 commits into from

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Nov 1, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR implements local Katana integration in the Starknet Remix Plugin. Users can now connect to a local Katana instance instead of using the is_alive endpoint, the version endpoint is used to check the health of the devnet. This PR modifies the DevnetAccountSelector and EnvironmentSelector components to make these changes.

Summary of Changes

  • Modified DevnetAccountSelector component:
    • Replaced the is_alive endpoint with the version endpoint in the checkDevnetUrl function.
    • Updated the condition in the if statement to check if the response does not contain a version number.
  • Modified EnvironmentSelector component:
    • Replaced the is_alive endpoint with the version endpoint in the handleEnvironmentChange function.
    • Updated the condition in the if statement to check if the response does not contain a version number.

Fixes #181.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Author

sweep-ai bot commented Nov 1, 2023

Sandbox Executions

  • Check plugin/src/components/DevnetAccountSelector/index.tsx
Sandbox logs for https://github.com/NethermindEth/starknet-remix-plugin/commit/d92ee01c60d708844bc7a7aae5e62e972b9c20ee
trunk fmt plugin/src/components/DevnetAccountSelector/index.tsx || exit 0 1/2 ✓
 ✔ Formatted plugin/src/components/DevnetAccountSelector/index.tsx
Re-checking autofixed files...


Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 2 linters
trunk check --fix --print-failures plugin/src/components/DevnetAccountSelector/index.tsx 2/2 ✓
Checked 1 file
✔ No issues
  • Check plugin/src/components/EnvironmentSelector/index.tsx
Run plugin/src/components/EnvironmentSelector/index.tsx through the sandbox.

Copy link
Author

sweep-ai bot commented Nov 1, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sweep-ai sweep-ai bot added the sweep label Nov 1, 2023
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-remix-plugin ❌ Failed (Inspect) Nov 3, 2023 11:39am

@sweep-ai sweep-ai bot mentioned this pull request Nov 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement local Katana integration
1 participant