-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Remix plugin UI styles with different Remix themes #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandbox Executions
Run plugin/src/components/DevnetAccountSelector/index.tsx through the sandbox.
Run plugin/src/components/EnvCard/index.tsx through the sandbox.
Run plugin/src/components/EnvironmentSelector/index.tsx through the sandbox.
Run plugin/src/components/ExplorerSelector/index.tsx through the sandbox.
Run plugin/src/components/JSONView/index.tsx through the sandbox.
Run plugin/src/components/ManualAccount/index.tsx through the sandbox.
Run plugin/src/components/NM/index.tsx through the sandbox.
Run plugin/src/components/NewTestnetAccount/index.tsx through the sandbox.
Run plugin/src/components/StateAction/index.tsx through the sandbox.
Run plugin/src/components/Wallet/index.tsx through the sandbox.
Run plugin/src/features/CairoVersion/index.tsx through the sandbox.
Run plugin/src/features/Compilation/index.tsx through the sandbox.
Run plugin/src/features/Deployment/index.tsx through the sandbox.
Run plugin/src/features/Environment/index.tsx through the sandbox.
Run plugin/src/features/Interaction/index.tsx through the sandbox.
Run plugin/src/features/Plugin/index.tsx through the sandbox.
Run plugin/src/features/TransactionHistory/index.tsx through the sandbox. |
Apply Sweep Rules to your PR?
|
36 tasks
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
You redefine the variables in many places. Please define the dark and light variables in one place and import them where needed. Create a reasonably named new file for this. |
🚀 Wrote ChangesDone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This PR aligns the UI styles of the Remix plugin with different Remix themes, such as light and dark. It introduces support for theme switching by using CSS variables and the
prefers-color-scheme
media feature. The modifications ensure that all UI components adapt to the selected theme, providing a consistent and visually appealing user experience.Summary of Changes
prefers-color-scheme
media feature to switch between light and dark themes.BackgroundNotices
,Card
,CompiledContracts
,DevnetAccountSelector
,EnvCard
,EnvironmentSelector
,ExplorerSelector
,JSONView
,ManualAccount
,NM
,NewTestnetAccount
,StateAction
,Wallet
,CairoVersion
,Compilation
,Deployment
,Environment
,Interaction
,Plugin
, andTransactionHistory
components to use the CSS variables and adapt to the selected theme.Please review and merge these changes to align the Remix plugin UI styles with different Remix themes.
Fixes #140.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: