Fix spammy log during snap sync (#7977)

NethermindEth · Dec 30, 2024 · 950a5a4 · 950a5a4
1 parent 68261dc
commit 950a5a4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Nethermind/Nethermind.Synchronization.Test/SnapSync/StateSyncPivotTest.cs b/src/Nethermind/Nethermind.Synchronization.Test/SnapSync/StateSyncPivotTest.cs
@@ -43,6 +43,6 @@ int syncPivot
         stateSyncPivot.GetPivotHeader().Should().NotBeNull();
 
         blockTree.BestSuggestedHeader.Returns(Build.A.BlockHeader.WithNumber(newBestSuggested).TestObject);
-        stateSyncPivot.GetPivotHeader().Number.Should().Be(newPivotHeader);
+        stateSyncPivot.GetPivotHeader()?.Number.Should().Be(newPivotHeader);
     }
 }
diff --git a/src/Nethermind/Nethermind.Synchronization/FastSync/StateSyncPivot.cs b/src/Nethermind/Nethermind.Synchronization/FastSync/StateSyncPivot.cs
@@ -16,7 +16,7 @@ namespace Nethermind.Synchronization.FastSync
     public class StateSyncPivot
     {
         private readonly IBlockTree _blockTree;
-        private BlockHeader _bestHeader;
+        private BlockHeader? _bestHeader;
         private readonly ILogger _logger;
         private readonly ISyncConfig _syncConfig;
 
@@ -35,7 +35,7 @@ public StateSyncPivot(IBlockTree blockTree, ISyncConfig syncConfig, ILogManager
             _logger = logManager?.GetClassLogger() ?? throw new ArgumentNullException(nameof(logManager));
         }
 
-        public BlockHeader GetPivotHeader()
+        public BlockHeader? GetPivotHeader()
         {
             if (_bestHeader is null || (_blockTree.BestSuggestedHeader?.Number + MultiSyncModeSelector.FastSyncLag) - _bestHeader.Number >= _syncConfig.StateMaxDistanceFromHead)
             {

diff --git a/src/Nethermind/Nethermind.Synchronization/SnapSync/ProgressTracker.cs b/src/Nethermind/Nethermind.Synchronization/SnapSync/ProgressTracker.cs
@@ -137,7 +137,7 @@ public void UpdatePivot()
 
         public bool IsFinished(out SnapSyncBatch? nextBatch)
         {
-            if (!CanSync())
+            if (_pivot.GetPivotHeader() is null)
             {
                 nextBatch = null;
                 return false;