Update Makefile

[AnkushinDaniil]

This pull request includes several updates to the Makefile to improve clarity and functionality. The most important changes include adding descriptions to various targets, ensuring the linter is run conditionally, and adding a new target for running a node with specific configurations.

Enhancements to target descriptions and functionality:

• Added descriptions to various targets to improve clarity, such as juno, generate, clean-testcache, test, test-cached, test-race, benchmarks, test-cover, install-deps, lint, tidy, format, clean, help, feedernode, node1, node2, node3, pathfinder, and test-fuzz. [1] [2] [3] [4] [5]

• Modified the install-golangci-lint target to use command -v instead of which for checking if golangci-lint is installed.

• Added a new target juno-cached with a description for cached Juno compilation.

• Added --disable-l1-verification flag to node targets (node1, node2, node3, pathfinder) to disable L1 verification.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (e3d6ccf) to head (8ae8750).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
- Coverage   75.41%   75.36%   -0.05%     
==========================================
  Files         107      107              
  Lines       11404    11404              
==========================================
- Hits         8600     8595       -5     
- Misses       2151     2153       +2     
- Partials      653      656       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kirugan]

in my opinion we need it only for vm and juno + also consider to move them on top of corresponding commands

[kirugan]

what difference between old and new versions ?

[AnkushinDaniil]

Key Differences

1. which Command:

   • Code:

     makefile
     Copy code
     @which golangci-lint || go install github.com/golangci/golangci-lint/cmd/[email protected]
     

   • Behavior:
     • which golangci-lint checks if golangci-lint is in the system's PATH.
     • If not found, which exits with a non-zero exit status, triggering the go install command.
   • Portability:
     • The which command is not built into all shells, so it might not work in environments where which is unavailable.

2. command -v Built-in:

   • Code:

     makefile
     Copy code
     @command -v golangci-lint >/dev/null 2>&1 || go install github.com/golangci/golangci-lint/cmd/[email protected]
     

   • Behavior:
     • command -v golangci-lint checks if golangci-lint is in the system's PATH using a shell built-in.
     • It outputs nothing to stdout (because of >/dev/null) and suppresses error messages (via 2>&1).
     • If the command does not exist, it exits with a non-zero status, triggering the go install command.
   • Portability:
     • command -v is POSIX-compliant and more portable across different systems compared to which.

Summary of Pros and Cons

Feature	which	command -v
Portability	Less portable (not always available)	More portable (POSIX-compliant)
Shell Dependency	External command	Built into most shells
Error Suppression	No built-in suppression mechanism	Can suppress both stdout and stderr easily
Preferred Use Case	For environments where which exists	General-purpose across platforms

[kirugan]

In my opinion we should keep it as it was. These commands are temporary for our convinience to test p2p

[kirugan]

we should keep it as it was

node1, node2, node3, pathfinder targets

[wojciechos]

LGTM