Refactor state and contract modules #2224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiihann
force-pushed
the
weiihann/refactor-state
branch
from
a9715c7
to
7670cbc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
- Coverage 75.63% 75.35% -0.28%
==========================================
Files 104 103 -1
Lines 11102 11168 +66
==========================================
+ Hits 8397 8416 +19
- Misses 2073 2104 +31
- Partials 632 648 +16 ☔ View full report in Codecov by Sentry. |
weiihann
requested review from
kirugan and
IronGauntlets
and removed request for
kirugan
weiihann
force-pushed
the
weiihann/refactor-state
branch
from
7670cbc
to
6a76c92
Compare
commit f5dc02c Author: Kirill <[email protected]> Date: Thu Oct 17 11:15:15 2024 +0400 Small restructure of plugin logic (#2221) commit b43c46f Author: Rian Hughes <[email protected]> Date: Wed Oct 16 15:42:07 2024 +0300 Support plugins (#2051) Co-authored-by: rian <[email protected]> Co-authored-by: LordGhostX <[email protected]> commit ca006de Author: Kirill <[email protected]> Date: Wed Oct 16 16:14:16 2024 +0400 Replace UnmarshalJSON() with UnmarshalText() for transaction statuses (#2220) * Replace UnmarshalJSON() with UnmarshalText() for transaction statuses UnmarshalText avoids issues with forgetting quotes in JSON, making it simpler for parsing plain text values. fix merge conflicts
weiihann
force-pushed
the
weiihann/refactor-state
branch
from
25465ba
to
c466cca
Compare
pnowosie
approved these changes
Oct 29, 2024
| } | ||
|
|
||
| if oldValue != nil { | ||
| if err = cb(&key, oldValue); err != nil { | ||
| if oldVal != nil && logChanges { |
There was a problem hiding this comment.
Checks the 2nd cond only if we care of logging
Suggested change
| if oldVal != nil && logChanges { | |
| if logChanges && oldVal != nil { |
| @@ -1,134 +0,0 @@ | |||
| package core | |||
There was a problem hiding this comment.
Do we have the functionality to read contract's historical data now?
I saw we log old values but can we read?
There was a problem hiding this comment.
👍 Ok they're implemented in state,go
| assert.Equal(t, replacedVal, nonce) | ||
|
|
||
| require.NoError(t, state.Revert(2, nonceStateUpdate)) | ||
| nonce, sErr = state.ContractNonce(new(felt.Felt).Set(&su1FirstDeployedAddress)) |
There was a problem hiding this comment.
Do we really need to pass a cloned value instead of the original (su1FirstDeployedAddress)
It's a bit hard to read 🤔
Also new(felt.Felt).SetUint64(n) 👇 bellow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has 2 major changes:
Combine
ContractNonce,ContractClassHash, andContractDeploymentHeightinto a single bucket calledContract.Separation of the contract fields in different buckets creates data duplication. Instead, we can encode them into a single object and store them in a single bucket. The slight performance degradation of encoding/decoding is insignificant as the fields are small.
Migration codes are added along with the unit tests.
Refactor
State.Update,State.Revertand the removal ofhistory.In the previous implementation, after applying each state diff (i.e. nonce, class hash, storage), the contract commitment is recalculated. This indicates that the higher the number of individual state diffs, the more times we need to recalculate the contract commitment.
In this new implementation, a contract's commitment is calculated only once after all state diffs are applied to a contract object. Now, the number of contract commitment calculations depends on the number of contracts updated.
Benchmark Results