Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db size command #2223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor db size command #2223

wants to merge 2 commits into from

Conversation

weiihann
Copy link
Contributor

@weiihann weiihann commented Oct 17, 2024

Description

This PR modifies the db size command to also check for leftover key-value pairs in the database. It also fixes an upper bound bug as the UpperBound iterator option is exclusive, not inclusive.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (f5dc02c) to head (1ecb18d).

Files with missing lines Patch % Lines
cmd/juno/dbcmd.go 50.00% 4 Missing and 2 partials ⚠️
db/pebble/db.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2223      +/-   ##
==========================================
- Coverage   78.39%   78.38%   -0.01%     
==========================================
  Files         104      104              
  Lines        9316     9338      +22     
==========================================
+ Hits         7303     7320      +17     
- Misses       1365     1368       +3     
- Partials      648      650       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant