Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctx to vm calls, simplify Throttler logic. #2102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Revert grpc updates

341151e
Select commit
Loading
Failed to load commit list.
Open

Add ctx to vm calls, simplify Throttler logic. #2102

Revert grpc updates
341151e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 1s

78.32% (target 70.00%)

View this Pull Request on Codecov

78.32% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (daf1cde) to head (341151e).
Report is 105 commits behind head on main.

Files with missing lines Patch % Lines
node/throttled_vm.go 63.63% 2 Missing and 2 partials ⚠️
utils/throttler.go 88.46% 3 Missing ⚠️
rpc/estimate_fee.go 71.42% 2 Missing ⚠️
rpc/trace.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   78.33%   78.32%   -0.01%     
==========================================
  Files         100      100              
  Lines        9115     9123       +8     
==========================================
+ Hits         7140     7146       +6     
- Misses       1339     1342       +3     
+ Partials      636      635       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.