Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update blockifier #1708

Closed
wants to merge 20 commits into from
Closed

update blockifier #1708

wants to merge 20 commits into from

Conversation

rianhughes
Copy link
Contributor

@rianhughes rianhughes commented Feb 16, 2024

closes #1707

Upgrade the compiler and blockifier dependencies (cairo 2.6.0 / blockifier 0.5.0)

Note: starknet_api also needed to be upgraded to work with the updated cairo-lang-X /blockifier deps

@rianhughes rianhughes force-pushed the rianhughes/0.13.1-blockfier-deps branch 5 times, most recently from a11856f to 7bddd53 Compare February 18, 2024 09:11
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.27%. Comparing base (6e8c601) to head (25ce749).

❗ Current head 25ce749 differs from pull request most recent head 0d6ae1f. Consider uploading reports for the commit 0d6ae1f to get more accurate results

Files Patch % Lines
node/throttled_vm.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   75.51%   75.27%   -0.24%     
==========================================
  Files          90       90              
  Lines        9631     9562      -69     
==========================================
- Hits         7273     7198      -75     
- Misses       1828     1830       +2     
- Partials      530      534       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rianhughes
Copy link
Contributor Author

rianhughes commented Feb 18, 2024

Note: there's are still a few todos, but it would be useful to get some input on them. Eg should we add new parameters to the Call/Execute functions?

@rianhughes rianhughes marked this pull request as ready for review February 19, 2024 08:43
@rianhughes rianhughes force-pushed the rianhughes/0.13.1-blockfier-deps branch from 3da1647 to 855b063 Compare February 20, 2024 10:52
@rianhughes rianhughes marked this pull request as draft February 20, 2024 11:38
@rianhughes rianhughes force-pushed the rianhughes/0.13.1-blockfier-deps branch 3 times, most recently from 708b5f7 to 1363ba0 Compare February 22, 2024 08:31
@rianhughes rianhughes marked this pull request as ready for review February 22, 2024 09:53
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
vm/vm.go Outdated Show resolved Hide resolved
vm/vm.go Show resolved Hide resolved
@omerfirmak
Copy link
Contributor

https://github.com/NethermindEth/juno/pull/1708/files#diff-8d744605e0447372940512f1f0ce8f36115ad8adf80941e0eb201bb7697d76b8R417

We need to pass "L1 data gas consumed" to go side as well.

@rianhughes rianhughes force-pushed the rianhughes/0.13.1-blockfier-deps branch from f20edc2 to f11b72d Compare February 26, 2024 07:39
node/throttled_vm.go Outdated Show resolved Hide resolved
vm/vm.go Outdated Show resolved Hide resolved
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
rpc/handlers.go Outdated Show resolved Hide resolved
@rianhughes
Copy link
Contributor Author

rianhughes commented Feb 27, 2024

0d6ae1f breaks TestV1Call for some reason? Tests pass on main, and 97bb768. But not when merged.

Failed to read from state: error parsing JSON string for class hash 0x01338d85d3e579f6944ba06c005238d145920afeb32f94e3a1e234d21e1e9292.

We should probably pass in a nested list of ints rather than
"BytecodeSegmentLengths": {
"Children": null,
"Length": 0
}

@omerfirmak
Copy link
Contributor

Closing in favor of #1728

@omerfirmak omerfirmak closed this Feb 27, 2024
@rianhughes rianhughes deleted the rianhughes/0.13.1-blockfier-deps branch August 22, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starknet 0.13.1 Interim blockifier deps
2 participants