Add errOnRevert flag to vm.Execute #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
force-pushed
the
omerfirmak/vm-revert-on-error
branch
3 times, most recently
from
2398191 to
bfbe3d4
Compare
joshklop
approved these changes
Dec 4, 2023
omerfirmak
force-pushed
the
omerfirmak/vm-revert-on-error
branch
from
bfbe3d4 to
2ed0f91
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
- Coverage 72.76% 72.75% -0.02%
==========================================
Files 96 96
Lines 9942 9942
==========================================
- Hits 7234 7233 -1
+ Misses 2167 2166 -1
- Partials 541 543 +2 ☔ View full report in Codecov by Sentry. |
omerfirmak
force-pushed
the
omerfirmak/vm-revert-on-error
branch
from
2ed0f91 to
f585e6a
Compare
to treat reverted txns as hard-failures
omerfirmak
force-pushed
the
omerfirmak/vm-revert-on-error
branch
from
f585e6a to
80cede6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to treat reverted txns as hard-failures