Remove ExtraData from Block as it is unused #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronGauntlets
requested review from
a team and
kirugan
and removed request for
a team
IronGauntlets
force-pushed
the
IronGauntlets/remove-extradata
branch
from
c0d6694
to
0825d38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
+ Coverage 72.76% 72.81% +0.04%
==========================================
Files 96 96
Lines 9943 9942 -1
==========================================
+ Hits 7235 7239 +4
+ Misses 2167 2162 -5
Partials 541 541 ☔ View full report in Codecov by Sentry. |
IronGauntlets
force-pushed
the
IronGauntlets/remove-extradata
branch
from
0825d38
to
8c14949
Compare
kirugan
approved these changes
Dec 4, 2023
IronGauntlets
force-pushed
the
IronGauntlets/remove-extradata
branch
from
8c14949
to
e5fb288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration was not required as I tested with a db containing some headers with and without ExtraData. The RPC was able to serve both without any issues.