Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rpc.ErrTransactionExecutionError #1475

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

omerfirmak
Copy link
Contributor

No description provided.

@omerfirmak omerfirmak requested review from a team and IronGauntlets and removed request for a team November 28, 2023 09:26
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (dfe9041) 72.95% compared to head (3bd9029) 72.89%.

Files Patch % Lines
rpc/handlers.go 61.11% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   72.95%   72.89%   -0.06%     
==========================================
  Files          93       93              
  Lines        9842     9852      +10     
==========================================
+ Hits         7180     7182       +2     
- Misses       2135     2139       +4     
- Partials      527      531       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omerfirmak omerfirmak marked this pull request as draft November 28, 2023 09:33
@omerfirmak omerfirmak force-pushed the omerfirmak/bump-blockifier branch 4 times, most recently from bc93647 to 7729e5b Compare November 28, 2023 11:19
@omerfirmak omerfirmak marked this pull request as ready for review November 28, 2023 11:32
vm/errors.go Outdated Show resolved Hide resolved
rpc/handlers.go Show resolved Hide resolved
rpc/handlers.go Show resolved Hide resolved
rpc/handlers.go Show resolved Hide resolved
@omerfirmak omerfirmak merged commit 6e23e06 into main Nov 29, 2023
8 of 10 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/bump-blockifier branch November 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants