Database: Configurable cache size #1467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 72.39% 72.38% -0.02%
==========================================
Files 93 93
Lines 9586 9592 +6
==========================================
+ Hits 6940 6943 +3
- Misses 2118 2120 +2
- Partials 528 529 +1 ☔ View full report in Codecov by Sentry. |
omerfirmak
reviewed
Nov 27, 2023
| @@ -61,6 +61,7 @@ const ( | |||
| maxVMQueueF = "max-vm-queue" | |||
| remoteDBF = "remote-db" | |||
| rpcMaxBlockScanF = "rpc-max-block-scan" | |||
| cacheSizeMbF = "cache-size-mb" | |||
There was a problem hiding this comment.
Suggested change
| cacheSizeMbF = "cache-size-mb" | |
| cacheSizeMbF = "db-cache-size" |
omerfirmak
reviewed
Nov 27, 2023
| @@ -113,6 +115,7 @@ const ( | |||
| maxVMQueueUsage = "Maximum number for requests to queue after reaching max-vms before starting to reject incoming requets" | |||
| remoteDBUsage = "gRPC URL of a remote Juno node" | |||
| rpcMaxBlockScanUsage = "Maximum number of blocks scanned in single starknet_getEvents call" | |||
| cacheSizeUsage = "Determines the amount of memory allocated for caching data in the database." | |||
There was a problem hiding this comment.
Suggested change
| cacheSizeUsage = "Determines the amount of memory allocated for caching data in the database." | |
| cacheSizeUsage = "Determines the amount of memory allocated for caching data in the database. (in megabytes)" |
|
Closing in favor of #1471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1458