Skip to content

Commit

Permalink
Add missing gomock.Controller.Finish() calls in plugin tests (#2225)
Browse files Browse the repository at this point in the history
  • Loading branch information
kirugan authored Oct 17, 2024
1 parent f5dc02c commit f4d9d69
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions plugin/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
func TestService(t *testing.T) {
t.Run("shutdown ok", func(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()

p := mocks.NewMockJunoPlugin(ctrl)
p.EXPECT().Shutdown().Return(nil)
Expand All @@ -28,6 +29,7 @@ func TestService(t *testing.T) {
})
t.Run("shutdown with error", func(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()

shutdownErr := errors.New("error during shutdown")

Expand Down

0 comments on commit f4d9d69

Please sign in to comment.