Fixes getStorageAt undeployed contract response

fix
NethermindEth · Nov 4, 2024 · ab431d2 · ab431d2
1 parent bf4aeda
commit ab431d2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/core/contract_test.go b/core/contract_test.go
@@ -171,7 +171,7 @@ func TestUpdateStorageAndStorage(t *testing.T) {
 		require.NoError(t, contract.UpdateStorage(map[felt.Felt]*felt.Felt{*addr: new(felt.Felt)}, NoopOnValueChanged))
 
 		val, err := core.ContractStorage(addr, addr, txn)
-		require.NoError(t, err)
+		require.Error(t, err)
 		require.Equal(t, &felt.Zero, val)
 
 		sRoot, err := core.ContractRoot(addr, txn)

diff --git a/core/trie/trie.go b/core/trie/trie.go
@@ -195,8 +195,8 @@ func (t *Trie) Get(key *felt.Felt) (*felt.Felt, error) {
 	storageKey := t.feltToKey(key)
 	value, err := t.storage.Get(&storageKey)
 	if err != nil {
-		if errors.Is(err, db.ErrKeyNotFound) {
-			return &felt.Zero, nil
+		if errors.Is(err, db.ErrKeyNotFound) { // a non-existent key returns a zero value
+			return &felt.Zero, db.ErrKeyNotFound
 		}
 		return nil, err
 	}

diff --git a/core/trie/trie_test.go b/core/trie/trie_test.go
@@ -47,7 +47,7 @@ func TestTriePut(t *testing.T) {
 			require.NoError(t, err)
 
 			value, err := tempTrie.Get(key)
-			assert.NoError(t, err)
+			assert.Error(t, err)
 			assert.Equal(t, &felt.Zero, value)
 			// Trie's root should be nil
 			assert.Nil(t, tempTrie.RootKey())
@@ -138,7 +138,7 @@ func TestTrieDeleteBasic(t *testing.T) {
 
 					val, err := tempTrie.Get(key)
 
-					assert.NoError(t, err, "shouldnt return an error when access a deleted key")
+					assert.Error(t, err, "should return an error when access a deleted key")
 					assert.Equal(t, &felt.Zero, val, "should return zero value when access a deleted key")
 				}