-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor transaction into batch and snapshot (#2182)
- Loading branch information
Showing
7 changed files
with
223 additions
and
150 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
package pebble | ||
|
||
import ( | ||
"errors" | ||
"sync" | ||
"time" | ||
|
||
"github.com/NethermindEth/juno/db" | ||
"github.com/NethermindEth/juno/utils" | ||
"github.com/cockroachdb/pebble" | ||
) | ||
|
||
var _ db.Transaction = (*batch)(nil) | ||
|
||
type batch struct { | ||
batch *pebble.Batch | ||
lock *sync.Mutex | ||
listener db.EventListener | ||
} | ||
|
||
func NewBatch(dbBatch *pebble.Batch, lock *sync.Mutex, listener db.EventListener) *batch { | ||
return &batch{ | ||
batch: dbBatch, | ||
lock: lock, | ||
listener: listener, | ||
} | ||
} | ||
|
||
// Discard : see db.Transaction.Discard | ||
func (b *batch) Discard() error { | ||
if b.batch == nil { | ||
return nil | ||
} | ||
|
||
err := b.batch.Close() | ||
b.batch = nil | ||
b.lock.Unlock() | ||
b.lock = nil | ||
|
||
return err | ||
} | ||
|
||
// Commit : see db.Transaction.Commit | ||
func (b *batch) Commit() error { | ||
if b.batch == nil { | ||
return ErrDiscardedTransaction | ||
} | ||
|
||
start := time.Now() | ||
defer func() { b.listener.OnCommit(time.Since(start)) }() | ||
return utils.RunAndWrapOnError(b.Discard, b.batch.Commit(pebble.Sync)) | ||
} | ||
|
||
// Set : see db.Transaction.Set | ||
func (b *batch) Set(key, val []byte) error { | ||
start := time.Now() | ||
if len(key) == 0 { | ||
return errors.New("empty key") | ||
} | ||
|
||
if b.batch == nil { | ||
return ErrDiscardedTransaction | ||
} | ||
|
||
defer func() { b.listener.OnIO(true, time.Since(start)) }() | ||
|
||
return b.batch.Set(key, val, pebble.Sync) | ||
} | ||
|
||
// Delete : see db.Transaction.Delete | ||
func (b *batch) Delete(key []byte) error { | ||
if b.batch == nil { | ||
return ErrDiscardedTransaction | ||
} | ||
|
||
start := time.Now() | ||
defer func() { b.listener.OnIO(true, time.Since(start)) }() | ||
|
||
return b.batch.Delete(key, pebble.Sync) | ||
} | ||
|
||
// Get : see db.Transaction.Get | ||
func (b *batch) Get(key []byte, cb func([]byte) error) error { | ||
if b.batch == nil { | ||
return ErrDiscardedTransaction | ||
} | ||
return get(b.batch, key, cb, b.listener) | ||
} | ||
|
||
// NewIterator : see db.Transaction.NewIterator | ||
func (b *batch) NewIterator() (db.Iterator, error) { | ||
var iter *pebble.Iterator | ||
var err error | ||
|
||
if b.batch == nil { | ||
return nil, ErrDiscardedTransaction | ||
} | ||
|
||
iter, err = b.batch.NewIter(nil) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
return &iterator{iter: iter}, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package pebble | ||
|
||
import ( | ||
"errors" | ||
"io" | ||
"time" | ||
|
||
"github.com/NethermindEth/juno/db" | ||
"github.com/NethermindEth/juno/utils" | ||
"github.com/cockroachdb/pebble" | ||
) | ||
|
||
type getter interface { | ||
Get([]byte) ([]byte, io.Closer, error) | ||
} | ||
|
||
func get(g getter, key []byte, cb func([]byte) error, listener db.EventListener) error { | ||
start := time.Now() | ||
var val []byte | ||
var closer io.Closer | ||
|
||
val, closer, err := g.Get(key) | ||
|
||
// We need it evaluated immediately so the duration doesn't include the runtime of the user callback that we call below. | ||
defer listener.OnIO(false, time.Since(start)) //nolint:govet | ||
if err != nil { | ||
if errors.Is(err, pebble.ErrNotFound) { | ||
return db.ErrKeyNotFound | ||
} | ||
return err | ||
} | ||
|
||
return utils.RunAndWrapOnError(closer.Close, cb(val)) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
package pebble | ||
|
||
import ( | ||
"github.com/NethermindEth/juno/db" | ||
"github.com/cockroachdb/pebble" | ||
) | ||
|
||
var _ db.Transaction = (*snapshot)(nil) | ||
|
||
type snapshot struct { | ||
snapshot *pebble.Snapshot | ||
listener db.EventListener | ||
} | ||
|
||
func NewSnapshot(dbSnapshot *pebble.Snapshot, listener db.EventListener) *snapshot { | ||
return &snapshot{ | ||
snapshot: dbSnapshot, | ||
listener: listener, | ||
} | ||
} | ||
|
||
// Discard : see db.Transaction.Discard | ||
func (s *snapshot) Discard() error { | ||
if s.snapshot == nil { | ||
return nil | ||
} | ||
|
||
if err := s.snapshot.Close(); err != nil { | ||
return err | ||
} | ||
|
||
s.snapshot = nil | ||
|
||
return nil | ||
} | ||
|
||
// Commit : see db.Transaction.Commit | ||
func (s *snapshot) Commit() error { | ||
return ErrReadOnlyTransaction | ||
} | ||
|
||
// Set : see db.Transaction.Set | ||
func (s *snapshot) Set(key, val []byte) error { | ||
return ErrReadOnlyTransaction | ||
} | ||
|
||
// Delete : see db.Transaction.Delete | ||
func (s *snapshot) Delete(key []byte) error { | ||
return ErrReadOnlyTransaction | ||
} | ||
|
||
// Get : see db.Transaction.Get | ||
func (s *snapshot) Get(key []byte, cb func([]byte) error) error { | ||
if s.snapshot == nil { | ||
return ErrDiscardedTransaction | ||
} | ||
return get(s.snapshot, key, cb, s.listener) | ||
} | ||
|
||
// NewIterator : see db.Transaction.NewIterator | ||
func (s *snapshot) NewIterator() (db.Iterator, error) { | ||
var iter *pebble.Iterator | ||
var err error | ||
|
||
if s.snapshot == nil { | ||
return nil, ErrDiscardedTransaction | ||
} | ||
|
||
iter, err = s.snapshot.NewIter(nil) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
return &iterator{iter: iter}, nil | ||
} |
Oops, something went wrong.