Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional permissions and switches to minimal #5639

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Adds additional permissions and switches to minimal #5639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d0881
Adds additional permissions and switches to minmal to prevent informa…
kevgliss Dec 19, 2024
b639795
Adjusting permissions
kevgliss Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dispatch/workflow/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Pagination,
)
from dispatch.participant.models import ParticipantRead
from dispatch.plugin.models import PluginInstance, PluginInstanceRead
from dispatch.plugin.models import PluginInstance, PluginInstanceReadMinimal
from dispatch.project.models import ProjectRead

from .enums import WorkflowInstanceStatus
Expand Down Expand Up @@ -121,7 +121,7 @@ class WorkflowSignal(DispatchBase):
class WorkflowBase(DispatchBase):
name: NameStr
resource_id: str
plugin_instance: PluginInstanceRead
plugin_instance: PluginInstanceReadMinimal
parameters: Optional[List[dict]] = []
enabled: Optional[bool]
description: Optional[str] = Field(None, nullable=True)
Expand Down
36 changes: 29 additions & 7 deletions src/dispatch/workflow/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from fastapi import APIRouter, HTTPException, status
from fastapi import APIRouter, HTTPException, status, Depends
from pydantic.error_wrappers import ErrorWrapper, ValidationError

from dispatch.database.core import DbSession
from dispatch.database.service import CommonParameters, search_filter_sort_paginate
from dispatch.auth.permissions import SensitiveProjectActionPermission, PermissionsDependency
from dispatch.exceptions import NotFoundError
from dispatch.models import PrimaryKey
from dispatch.plugin import service as plugin_service
Expand All @@ -27,7 +28,10 @@ def get_workflows(common: CommonParameters):
return search_filter_sort_paginate(model="Workflow", **common)


@router.get("/{workflow_id}", response_model=WorkflowRead)
@router.get(
"/{workflow_id}",
response_model=WorkflowRead,
)
def get_workflow(db_session: DbSession, workflow_id: PrimaryKey):
"""Get a workflow."""
workflow = get(db_session=db_session, workflow_id=workflow_id)
Expand All @@ -39,7 +43,10 @@ def get_workflow(db_session: DbSession, workflow_id: PrimaryKey):
return workflow


@router.get("/instances/{workflow_instance_id}", response_model=WorkflowInstanceRead)
@router.get(
"/instances/{workflow_instance_id}",
response_model=WorkflowInstanceRead,
)
def get_workflow_instance(db_session: DbSession, workflow_instance_id: PrimaryKey):
"""Get a workflow instance."""
workflow_instance = get_instance(db_session=db_session, instance_id=workflow_instance_id)
Expand All @@ -51,7 +58,11 @@ def get_workflow_instance(db_session: DbSession, workflow_instance_id: PrimaryKe
return workflow_instance


@router.post("", response_model=WorkflowRead)
@router.post(
"",
response_model=WorkflowRead,
dependencies=[Depends(PermissionsDependency([SensitiveProjectActionPermission]))],
)
def create_workflow(db_session: DbSession, workflow_in: WorkflowCreate):
"""Create a new workflow."""
plugin_instance = plugin_service.get_instance(
Expand All @@ -66,7 +77,11 @@ def create_workflow(db_session: DbSession, workflow_in: WorkflowCreate):
return create(db_session=db_session, workflow_in=workflow_in)


@router.put("/{workflow_id}", response_model=WorkflowRead)
@router.put(
"/{workflow_id}",
response_model=WorkflowRead,
dependencies=[Depends(PermissionsDependency([SensitiveProjectActionPermission]))],
)
def update_workflow(db_session: DbSession, workflow_id: PrimaryKey, workflow_in: WorkflowUpdate):
"""Update a workflow."""
workflow = get(db_session=db_session, workflow_id=workflow_id)
Expand All @@ -78,7 +93,11 @@ def update_workflow(db_session: DbSession, workflow_id: PrimaryKey, workflow_in:
return update(db_session=db_session, workflow=workflow, workflow_in=workflow_in)


@router.delete("/{workflow_id}", response_model=None)
@router.delete(
"/{workflow_id}",
response_model=None,
dependencies=[Depends(PermissionsDependency([SensitiveProjectActionPermission]))],
)
def delete_workflow(db_session: DbSession, workflow_id: PrimaryKey):
"""Delete a workflow."""
workflow = get(db_session=db_session, workflow_id=workflow_id)
Expand All @@ -90,7 +109,10 @@ def delete_workflow(db_session: DbSession, workflow_id: PrimaryKey):
delete(db_session=db_session, workflow_id=workflow_id)


@router.post("/{workflow_id}/run", response_model=WorkflowInstanceRead)
@router.post(
"/{workflow_id}/run",
response_model=WorkflowInstanceRead,
)
def run_workflow(
db_session: DbSession,
workflow_id: PrimaryKey,
Expand Down
Loading