Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(case): close escalated case when associated incident is closed #5618

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

whitdog47
Copy link
Contributor

This PR ensures that when an incident is closed, all associated escalated cases are automatically closed and their case resolution includes a message indicating closure as part of the incident. Fixes DISDEV-243.

@whitdog47 whitdog47 added bug Something isn't working techdebt labels Dec 13, 2024
@whitdog47 whitdog47 self-assigned this Dec 13, 2024
Copy link
Contributor

@wssheldon wssheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good looks

This feels more like an enhancement to me and less a bug -- along the same lines I wouldn't consider this tech debt (us being on SQLAlchemy 1.2 is tech debt, as an example, from my perspective).

Co-authored-by: Will Sheldon <[email protected]>
Signed-off-by: David Whittaker <[email protected]>
@whitdog47 whitdog47 added enhancement New feature or request and removed bug Something isn't working techdebt labels Dec 13, 2024
@whitdog47 whitdog47 merged commit 71114e7 into master Dec 14, 2024
8 checks passed
@whitdog47 whitdog47 deleted the bugfix/close-escalated-case-when-incident-closes branch December 14, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants