Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): check if challenge is already approved before raising exception #5445

Merged
merged 1 commit into from
Nov 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/dispatch/plugins/dispatch_core/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,9 @@ def validate_mfa_token(
raise ActionMismatchError("Action mismatch")
if not challenge.valid:
raise ExpiredChallengeError("Challenge is no longer valid")
if challenge.status == MfaChallengeStatus.APPROVED:
# Challenge has already been approved
return challenge.status
if challenge.status != MfaChallengeStatus.PENDING:
raise InvalidChallengeStateError(f"Challenge is in invalid state: {challenge.status}")

Expand Down
Loading