Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): dockerfile suggestions, lint and errors handling #5264

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat(docker): dockerfile suggestions, lint and errors handling #5264

merged 2 commits into from
Oct 1, 2024

Conversation

Ant0wan
Copy link
Contributor

@Ant0wan Ant0wan commented Sep 30, 2024

Description

Improved the Dockerfile by:

  • Adding stricter error handling with SHELL options
  • Simplifying RUN commands by removing set -x usage
  • Removing unnecessary cache where possible
  • Switching to pushd/popd for directory changes for linting purposes

These changes make the build process more reliable and reduce the image size a little.

@mvilanova mvilanova merged commit 8796b00 into Netflix:master Oct 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants