Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turns off unfurling links and adds conversation link to help tips #4938

Merged
merged 2 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dispatch/incident/messaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -1176,6 +1176,7 @@ def send_incident_management_help_tips_message(incident: Incident, db_session: S
"executive_report_command": executive_report_command,
"tactical_report_command": tactical_report_command,
"update_command": update_command,
"conversation_weblink": resolve_attr(incident, "conversation.weblink"),
}
]

Expand Down
2 changes: 1 addition & 1 deletion src/dispatch/messaging/strings.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ class MessageType(DispatchEnum):
Thanks for participating in the {{name}} ("{{title}}") incident. We would appreciate if you could rate your experience and provide feedback."""

INCIDENT_MANAGEMENT_HELP_TIPS_MESSAGE_DESCRIPTION = """
Hey, I see you're the Incident Commander for {{name}} ("{{title}}"). Here are a few things to consider when managing the incident:
Hey, I see you're the Incident Commander for <{{conversation_weblink}}|{{name}}> ("{{title}}"). Here are a few things to consider when managing the incident:
\n • Keep the incident and its status up to date using the Slack `{{update_command}}` command.
\n • Invite incident participants and team oncalls by mentioning them in the incident channel or using the Slack `{{engage_oncall_command}}` command.
\n • Keep incident participants and stakeholders informed by creating tactical and executive reports using the `{{tactical_report_command}}` and `{{executive_report_command}}` commands.
Expand Down
1 change: 1 addition & 0 deletions src/dispatch/plugins/dispatch_slack/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ def send_message(
text=text,
thread_ts=ts,
blocks=blocks,
unfurl_links=False,
)

if persist:
Expand Down
Loading