Log a warning if the exception in case add thread flow is users not found #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitdog47
requested changes
Mar 6, 2024
wssheldon
commented
Mar 6, 2024
wssheldon
commented
Mar 6, 2024
whitdog47
approved these changes
Mar 6, 2024
wssheldon
commented
Mar 6, 2024
whitdog47
reviewed
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are automatically engaged in Slack Case threads frequently who did not exist in the workspace. We can log this as a warning and move on.
Tested this locally by creating a case via an ingested Signal:
... WARNING:Unable to resolve Slack participant: The request to the Slack API failed. (url: https://www.slack.com/api/users.lookupByEmail) The server responded with: {'ok': False, 'error': 'users_not_found'}:/Users/wshel/Projects/dispatch/src/dispatch/plugins/dispatch_slack/service.py:emails_to_user_ids:72 DEBUG:function.elapsed.time.dispatch.plugins.dispatch_slack.plugin.SlackConversationPlugin.add_to_thread: 0.2627900000079535:/Users/wshel/Projects/dispatch/src/dispatch/decorators.py:wrapper:139You can see above we now log a
WARNINGwhen the user cannot be resolved in theadd_to_threadcode flow.